Re: [PATCH] fs:ext3: remove lock_buffer in bclean() and setup_new_group_blocks

2012-12-05 Thread Jan Kara
On Sun 02-12-12 01:40:28, Cong Ding wrote: > it's not necessary to lock the buffers because no one touches them > beyond the file system. Although I agree those locks are not strictly necessary, I prefer to keep them because the general rula is buffer contents should be changed under buffer lock

Re: [PATCH] fs:ext3: remove lock_buffer in bclean() and setup_new_group_blocks

2012-12-05 Thread Jan Kara
On Sun 02-12-12 01:40:28, Cong Ding wrote: it's not necessary to lock the buffers because no one touches them beyond the file system. Although I agree those locks are not strictly necessary, I prefer to keep them because the general rula is buffer contents should be changed under buffer lock

[PATCH] fs:ext3: remove lock_buffer in bclean() and setup_new_group_blocks

2012-12-01 Thread Cong Ding
it's not necessary to lock the buffers because no one touches them beyond the file system. Signed-off-by: Cong Ding --- fs/ext3/resize.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c index 0f814f3..f76fcd6 100644 ---

[PATCH] fs:ext3: remove lock_buffer in bclean() and setup_new_group_blocks

2012-12-01 Thread Cong Ding
it's not necessary to lock the buffers because no one touches them beyond the file system. Signed-off-by: Cong Ding ding...@gmail.com --- fs/ext3/resize.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c index 0f814f3..f76fcd6 100644