Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-26 Thread Steven Rostedt
On Mon, 24 Aug 2020 17:29:32 -0700 (PDT) Palmer Dabbelt wrote: > I pointed out in the patch notes that it seems reasonable to have the generic > code handle this case, would you be opposed to doing it that way? For now, lets hold off and see if other archs start to do it the same way. Then we

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-24 Thread Palmer Dabbelt
On Thu, 13 Aug 2020 08:37:43 PDT (-0700), rost...@goodmis.org wrote: On Wed, 12 Aug 2020 22:13:19 -0700 (PDT) Palmer Dabbelt wrote: Sorry, I'm not really sure what's going on here. I'm not really seeing code that matches this in our port right now, so maybe this is aginst some other tree?

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-13 Thread Steven Rostedt
On Wed, 12 Aug 2020 22:13:19 -0700 (PDT) Palmer Dabbelt wrote: > Sorry, I'm not really sure what's going on here. I'm not really seeing code > that matches this in our port right now, so maybe this is aginst some other > tree? If it's the RISC-V kprobes patch set then I was hoping to take a

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-12 Thread Palmer Dabbelt
On Thu, 06 Aug 2020 22:01:01 PDT (-0700), guo...@kernel.org wrote: On Fri, Aug 7, 2020 at 12:01 PM Steven Rostedt wrote: On Fri, 7 Aug 2020 10:59:16 +0800 Guo Ren wrote: > > > > This looks like a bug in the lockdep_assert_held() in whatever arch > > (riscv) is running. > Seems you think it's

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-06 Thread Guo Ren
On Fri, Aug 7, 2020 at 12:01 PM Steven Rostedt wrote: > > On Fri, 7 Aug 2020 10:59:16 +0800 > Guo Ren wrote: > > > > > > This looks like a bug in the lockdep_assert_held() in whatever arch > > > (riscv) is running. > > Seems you think it's a bug of arch implementation with the wrong usage > > of

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-06 Thread Steven Rostedt
On Fri, 7 Aug 2020 10:59:16 +0800 Guo Ren wrote: > > > > This looks like a bug in the lockdep_assert_held() in whatever arch > > (riscv) is running. > Seems you think it's a bug of arch implementation with the wrong usage > of text_mutex? > > Also @riscv maintainer, > How about modifying it in

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-06 Thread Guo Ren
On Thu, Aug 6, 2020 at 11:48 PM Steven Rostedt wrote: > > On Thu, 6 Aug 2020 14:50:54 + > guo...@kernel.org wrote: > > > From: Guo Ren > > > > The function ftrace_process_locs() will modify text code, so we > > should give a text_mutex lock. Because some arch's patch code > > will assert

[PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-06 Thread guoren
From: Guo Ren The function ftrace_process_locs() will modify text code, so we should give a text_mutex lock. Because some arch's patch code will assert held of text_mutex even during start_kernel-> ftrace_init(). backtrace log: assert by lockdep_assert_held(_mutex) 0 patch_insn_write

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-06 Thread Steven Rostedt
On Thu, 6 Aug 2020 14:50:54 + guo...@kernel.org wrote: > From: Guo Ren > > The function ftrace_process_locs() will modify text code, so we > should give a text_mutex lock. Because some arch's patch code > will assert held of text_mutex even during start_kernel-> > ftrace_init(). NAK.