Re: [PATCH] gpio: Add Tegra186 support

On Thursday 24 November 2016 08:38 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Nov 24, 2016 at 08:14:31PM +0530, Laxman Dewangan wrote: This has nothing to do with the device tree binding. What the device tree binding defines is the indices to use to obtain a given GPIO

Re: [PATCH] gpio: Add Tegra186 support

On Thursday 24 November 2016 08:38 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Nov 24, 2016 at 08:14:31PM +0530, Laxman Dewangan wrote: This has nothing to do with the device tree binding. What the device tree binding defines is the indices to use to obtain a given GPIO

Re: [PATCH] gpio: Add Tegra186 support

On Wed, Nov 23, 2016 at 8:44 PM, Thierry Reding wrote: > On Wed, Nov 23, 2016 at 02:30:45PM +0100, Linus Walleij wrote: >> On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding >> wrote: >> >> > From: Thierry Reding >> > >> >

Re: [PATCH] gpio: Add Tegra186 support

On Wed, Nov 23, 2016 at 8:44 PM, Thierry Reding wrote: > On Wed, Nov 23, 2016 at 02:30:45PM +0100, Linus Walleij wrote: >> On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding >> wrote: >> >> > From: Thierry Reding >> > >> > Tegra186 has two GPIO controllers that are largely register compatible >> >

Re: [PATCH] gpio: Add Tegra186 support

On Thu, Nov 24, 2016 at 08:14:31PM +0530, Laxman Dewangan wrote: > > On Thursday 24 November 2016 08:14 PM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Thu, Nov 24, 2016 at 12:23:56PM +0530, Laxman Dewangan wrote: > > > On Tuesday 22 November 2016 11:25 PM, Thierry Reding

Re: [PATCH] gpio: Add Tegra186 support

On Thu, Nov 24, 2016 at 08:14:31PM +0530, Laxman Dewangan wrote: > > On Thursday 24 November 2016 08:14 PM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Thu, Nov 24, 2016 at 12:23:56PM +0530, Laxman Dewangan wrote: > > > On Tuesday 22 November 2016 11:25 PM, Thierry Reding

Re: [PATCH] gpio: Add Tegra186 support

On Thursday 24 November 2016 08:14 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Nov 24, 2016 at 12:23:56PM +0530, Laxman Dewangan wrote: On Tuesday 22 November 2016 11:25 PM, Thierry Reding wrote: +static inline struct tegra_gpio *to_tegra_gpio(struct gpio_chip *chip) +{

Re: [PATCH] gpio: Add Tegra186 support

On Thursday 24 November 2016 08:14 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Thu, Nov 24, 2016 at 12:23:56PM +0530, Laxman Dewangan wrote: On Tuesday 22 November 2016 11:25 PM, Thierry Reding wrote: +static inline struct tegra_gpio *to_tegra_gpio(struct gpio_chip *chip) +{

Re: [PATCH] gpio: Add Tegra186 support

On Thu, Nov 24, 2016 at 12:23:56PM +0530, Laxman Dewangan wrote: > > On Tuesday 22 November 2016 11:25 PM, Thierry Reding wrote: > > +static inline struct tegra_gpio *to_tegra_gpio(struct gpio_chip *chip) > > +{ > > + return container_of(chip, struct tegra_gpio, gpio); > > +} > > You dont need

Re: [PATCH] gpio: Add Tegra186 support

On Thu, Nov 24, 2016 at 12:23:56PM +0530, Laxman Dewangan wrote: > > On Tuesday 22 November 2016 11:25 PM, Thierry Reding wrote: > > +static inline struct tegra_gpio *to_tegra_gpio(struct gpio_chip *chip) > > +{ > > + return container_of(chip, struct tegra_gpio, gpio); > > +} > > You dont need

Re: [PATCH] gpio: Add Tegra186 support

On Tuesday 22 November 2016 11:25 PM, Thierry Reding wrote: +static inline struct tegra_gpio *to_tegra_gpio(struct gpio_chip *chip) +{ + return container_of(chip, struct tegra_gpio, gpio); +} You dont need this as gpiochip_get_data(chip); can provide the required driver specific data.

Re: [PATCH] gpio: Add Tegra186 support

On Tuesday 22 November 2016 11:25 PM, Thierry Reding wrote: +static inline struct tegra_gpio *to_tegra_gpio(struct gpio_chip *chip) +{ + return container_of(chip, struct tegra_gpio, gpio); +} You dont need this as gpiochip_get_data(chip); can provide the required driver specific data.

Re: [PATCH] gpio: Add Tegra186 support

On Wed, Nov 23, 2016 at 02:30:45PM +0100, Linus Walleij wrote: > On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding > wrote: > > > From: Thierry Reding > > > > Tegra186 has two GPIO controllers that are largely register compatible > > between one

Re: [PATCH] gpio: Add Tegra186 support

On Wed, Nov 23, 2016 at 02:30:45PM +0100, Linus Walleij wrote: > On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding > wrote: > > > From: Thierry Reding > > > > Tegra186 has two GPIO controllers that are largely register compatible > > between one another but are completely different from the

Re: [PATCH] gpio: Add Tegra186 support

On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding wrote: > From: Thierry Reding > > Tegra186 has two GPIO controllers that are largely register compatible > between one another but are completely different from the controller > found on earlier

Re: [PATCH] gpio: Add Tegra186 support

On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding wrote: > From: Thierry Reding > > Tegra186 has two GPIO controllers that are largely register compatible > between one another but are completely different from the controller > found on earlier generations. > > Signed-off-by: Thierry Reding I

[PATCH] gpio: Add Tegra186 support

From: Thierry Reding Tegra186 has two GPIO controllers that are largely register compatible between one another but are completely different from the controller found on earlier generations. Signed-off-by: Thierry Reding --- drivers/gpio/Kconfig

[PATCH] gpio: Add Tegra186 support

From: Thierry Reding Tegra186 has two GPIO controllers that are largely register compatible between one another but are completely different from the controller found on earlier generations. Signed-off-by: Thierry Reding --- drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile|