Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-06-05 Thread Rabin Vincent
On Mon, Jun 01, 2015 at 03:45:35PM +0200, Linus Walleij wrote: > There is also the code such as of_gpio_simple_xlate() > that can't be reused for this, so thus it needs its own xlate > function and adds some complexity to the code. > But the convention in of_gpio_simple_xlate() is that > cell 0 is

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-06-05 Thread Rabin Vincent
On Mon, Jun 01, 2015 at 03:45:35PM +0200, Linus Walleij wrote: There is also the code such as of_gpio_simple_xlate() that can't be reused for this, so thus it needs its own xlate function and adds some complexity to the code. But the convention in of_gpio_simple_xlate() is that cell 0 is

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-06-01 Thread Linus Walleij
On Thu, May 21, 2015 at 8:48 PM, Rabin Vincent wrote: > On Tue, May 19, 2015 at 11:39:01AM +0200, Linus Walleij wrote: >> Three cells is rather unusual, is it the best arrangement? >> >> Usually it's just offset+flags (your flags are ununsed I see). >> And then you could divide offset by num

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-06-01 Thread Linus Walleij
On Thu, May 21, 2015 at 8:48 PM, Rabin Vincent ra...@rab.in wrote: On Tue, May 19, 2015 at 11:39:01AM +0200, Linus Walleij wrote: Three cells is rather unusual, is it the best arrangement? Usually it's just offset+flags (your flags are ununsed I see). And then you could divide offset by num

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-21 Thread Rabin Vincent
On Sat, May 16, 2015 at 03:59:27PM +0200, Paul Bolle wrote: > On Sat, 2015-05-16 at 00:27 +0200, Rabin Vincent wrote: > > +obj-$(CONFIG_GPIO_ETRAXFS) += gpio-etraxfs.o > > GPIO_ETRAXFS is a bool symbol, so gpio-etraxfs.o can only be built-in, > right? Right. > > --- /dev/null > > +++

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-21 Thread Rabin Vincent
On Tue, May 19, 2015 at 11:39:01AM +0200, Linus Walleij wrote: > On Sat, May 16, 2015 at 12:27 AM, Rabin Vincent wrote: > > +Axis ETRAX FS General I/O controller bindings > > + > > +Required properties: > > + > > +- compatible: > > + - "axis,etraxfs-gio" > > +- reg: Physical base address and

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-21 Thread Rabin Vincent
On Tue, May 19, 2015 at 11:39:01AM +0200, Linus Walleij wrote: On Sat, May 16, 2015 at 12:27 AM, Rabin Vincent ra...@rab.in wrote: +Axis ETRAX FS General I/O controller bindings + +Required properties: + +- compatible: + - axis,etraxfs-gio +- reg: Physical base address and length

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-21 Thread Rabin Vincent
On Sat, May 16, 2015 at 03:59:27PM +0200, Paul Bolle wrote: On Sat, 2015-05-16 at 00:27 +0200, Rabin Vincent wrote: +obj-$(CONFIG_GPIO_ETRAXFS) += gpio-etraxfs.o GPIO_ETRAXFS is a bool symbol, so gpio-etraxfs.o can only be built-in, right? Right. --- /dev/null +++

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-19 Thread Linus Walleij
On Sat, May 16, 2015 at 12:27 AM, Rabin Vincent wrote: > Add a GPIO driver for the General I/O block on Axis ETRAX FS SoCs. > > Signed-off-by: Rabin Vincent Nice! (...) > +++ b/Documentation/devicetree/bindings/gpio/gpio-etraxfs.txt > @@ -0,0 +1,21 @@ > +Axis ETRAX FS General I/O controller

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-19 Thread Linus Walleij
On Sat, May 16, 2015 at 12:27 AM, Rabin Vincent ra...@rab.in wrote: Add a GPIO driver for the General I/O block on Axis ETRAX FS SoCs. Signed-off-by: Rabin Vincent ra...@rab.in Nice! (...) +++ b/Documentation/devicetree/bindings/gpio/gpio-etraxfs.txt @@ -0,0 +1,21 @@ +Axis ETRAX FS

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-16 Thread Paul Bolle
On Sat, 2015-05-16 at 00:27 +0200, Rabin Vincent wrote: > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > +config GPIO_ETRAXFS > + bool "Axis ETRAX FS General I/O" > + depends on CRIS || COMPILE_TEST > + depends on OF > + select GPIO_GENERIC > + help > + Say

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-05-16 Thread Paul Bolle
On Sat, 2015-05-16 at 00:27 +0200, Rabin Vincent wrote: --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig +config GPIO_ETRAXFS + bool Axis ETRAX FS General I/O + depends on CRIS || COMPILE_TEST + depends on OF + select GPIO_GENERIC + help + Say yes here to

[PATCH] gpio: add ETRAXFS GPIO driver

2015-05-15 Thread Rabin Vincent
Add a GPIO driver for the General I/O block on Axis ETRAX FS SoCs. Signed-off-by: Rabin Vincent --- .../devicetree/bindings/gpio/gpio-etraxfs.txt | 21 +++ drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile | 1 +

[PATCH] gpio: add ETRAXFS GPIO driver

2015-05-15 Thread Rabin Vincent
Add a GPIO driver for the General I/O block on Axis ETRAX FS SoCs. Signed-off-by: Rabin Vincent ra...@rab.in --- .../devicetree/bindings/gpio/gpio-etraxfs.txt | 21 +++ drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile | 1 +