Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-12-06 Thread Linus Walleij
On Thu, Dec 6, 2012 at 4:49 AM, Vivien Didelot wrote: > I looked at some drivers and if I'm not mistaken, this case is > different. Technologic Systems platforms (such as the TS-5500) have > several pin blocks. Each block has input-only, input-output or > output-only pins. Only one pin per block

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-12-06 Thread Linus Walleij
On Thu, Dec 6, 2012 at 4:49 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: I looked at some drivers and if I'm not mistaken, this case is different. Technologic Systems platforms (such as the TS-5500) have several pin blocks. Each block has input-only, input-output or

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-12-05 Thread Vivien Didelot
Hi Linus, I rewrote some parts according to your comments, but I still have some concerns. On Fri, 2012-10-12 at 22:53 +0200, Linus Walleij wrote: > >> (...) > >> > +static int ts5500_gpio_to_irq(struct gpio_chip *chip, unsigned > offset) > >> > +{ > >> > + const struct ts5500_dio line =

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-12-05 Thread Vivien Didelot
Hi Linus, I rewrote some parts according to your comments, but I still have some concerns. On Fri, 2012-10-12 at 22:53 +0200, Linus Walleij wrote: (...) +static int ts5500_gpio_to_irq(struct gpio_chip *chip, unsigned offset) +{ + const struct ts5500_dio line =

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-12 Thread Linus Walleij
On Sat, Oct 13, 2012 at 12:04 AM, Vivien Didelot wrote: > About the generic driver (to allow registering one platform device per > DIO block), I think it won't be possible, because there are shared > regions, such as 0x7d, used by DIO2 and LCD DIO for direction... Probably true. > Is there a

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-12 Thread Vivien Didelot
Hi Linus, On Fri, 2012-10-12 at 22:53 +0200, Linus Walleij wrote: > Well that may also be a pretty big step if you just want to mux > one bank of GPIO. I'm a bit ambivalent. But if you want to tie > pin and gpio information together and name all pins, pinctrl > is what should suit you best. > >

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-12 Thread Linus Walleij
On Mon, Oct 8, 2012 at 8:20 PM, Vivien Didelot wrote: > On Mon, 2012-10-08 at 12:38 +0200, Linus Walleij wrote: >> On Wed, Sep 26, 2012 at 2:42 AM, Vivien Didelot >> wrote: >> Part of me dislike that you create one single driver for all >> three blocks instead of abstracting the driver to

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-12 Thread Linus Walleij
On Mon, Oct 8, 2012 at 8:20 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: On Mon, 2012-10-08 at 12:38 +0200, Linus Walleij wrote: On Wed, Sep 26, 2012 at 2:42 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: Part of me dislike that you create one single driver for

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-12 Thread Vivien Didelot
Hi Linus, On Fri, 2012-10-12 at 22:53 +0200, Linus Walleij wrote: Well that may also be a pretty big step if you just want to mux one bank of GPIO. I'm a bit ambivalent. But if you want to tie pin and gpio information together and name all pins, pinctrl is what should suit you best. In the

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-12 Thread Linus Walleij
On Sat, Oct 13, 2012 at 12:04 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: About the generic driver (to allow registering one platform device per DIO block), I think it won't be possible, because there are shared regions, such as 0x7d, used by DIO2 and LCD DIO for direction...

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Vivien Didelot
Hi Linus, On Mon, 2012-10-08 at 12:38 +0200, Linus Walleij wrote: > On Wed, Sep 26, 2012 at 2:42 AM, Vivien Didelot > wrote: > > > The Technologic Systems TS-5500 platform provides 3 digital I/O headers: > > DIO1, DIO2, and the LCD port, that may be used as a DIO header. > > > > Signed-off-by:

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Linus Walleij
On Wed, Sep 26, 2012 at 2:42 AM, Vivien Didelot wrote: > The Technologic Systems TS-5500 platform provides 3 digital I/O headers: > DIO1, DIO2, and the LCD port, that may be used as a DIO header. > > Signed-off-by: Vivien Didelot > Signed-off-by: Jerome Oufella (...) > + * The TS-5500 platform

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Linus Walleij
On Fri, Oct 5, 2012 at 1:18 AM, Vivien Didelot wrote: > Grant, Linus, any feedback? On the entire driver or on the config fragment? The latter looks OK, I'll look at the driver per se now. (I was busy with the merge window you know...) Yours, Linus Walleij -- To unsubscribe from this list:

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Linus Walleij
On Fri, Oct 5, 2012 at 1:18 AM, Vivien Didelot vivien.dide...@gmail.com wrote: Grant, Linus, any feedback? On the entire driver or on the config fragment? The latter looks OK, I'll look at the driver per se now. (I was busy with the merge window you know...) Yours, Linus Walleij -- To

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Linus Walleij
On Wed, Sep 26, 2012 at 2:42 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: The Technologic Systems TS-5500 platform provides 3 digital I/O headers: DIO1, DIO2, and the LCD port, that may be used as a DIO header. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Vivien Didelot
Hi Linus, On Mon, 2012-10-08 at 12:38 +0200, Linus Walleij wrote: On Wed, Sep 26, 2012 at 2:42 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: The Technologic Systems TS-5500 platform provides 3 digital I/O headers: DIO1, DIO2, and the LCD port, that may be used as a DIO

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-04 Thread Vivien Didelot
Hi, Grant, Linus, any feedback? Thanks, Vivien On Wed, 2012-09-26 at 11:37 -0400, Vivien Didelot wrote: > > +config GPIO_TS5500 > > + tristate "TS-5500 DIO Headers" > > + depends on TS5500 > > + help > > + This driver supports the 3 Digital I/O headers of the > Technologic > >

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-04 Thread Vivien Didelot
Hi, Grant, Linus, any feedback? Thanks, Vivien On Wed, 2012-09-26 at 11:37 -0400, Vivien Didelot wrote: +config GPIO_TS5500 + tristate TS-5500 DIO Headers + depends on TS5500 + help + This driver supports the 3 Digital I/O headers of the Technologic +

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-09-26 Thread Vivien Didelot
Hi, I think the Kconfig patch is wrong, please do not consider this patchset. I'll send a v2 very soon. On Tue, 2012-09-25 at 20:42 -0400, Vivien Didelot wrote: > The Technologic Systems TS-5500 platform provides 3 digital I/O headers: > DIO1, DIO2, and the LCD port, that may be used as a DIO

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-09-26 Thread Vivien Didelot
Hi, I think the Kconfig patch is wrong, please do not consider this patchset. I'll send a v2 very soon. On Tue, 2012-09-25 at 20:42 -0400, Vivien Didelot wrote: The Technologic Systems TS-5500 platform provides 3 digital I/O headers: DIO1, DIO2, and the LCD port, that may be used as a DIO

[PATCH] gpio: add TS-5500 DIO headers support

2012-09-25 Thread Vivien Didelot
The Technologic Systems TS-5500 platform provides 3 digital I/O headers: DIO1, DIO2, and the LCD port, that may be used as a DIO header. Signed-off-by: Vivien Didelot Signed-off-by: Jerome Oufella --- drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile

[PATCH] gpio: add TS-5500 DIO headers support

2012-09-25 Thread Vivien Didelot
The Technologic Systems TS-5500 platform provides 3 digital I/O headers: DIO1, DIO2, and the LCD port, that may be used as a DIO header. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com Signed-off-by: Jerome Oufella jerome.oufe...@savoirfairelinux.com --- drivers/gpio/Kconfig