Re: [PATCH] gpio: dwapb: add support for new hisilicon ascend soc

2020-09-12 Thread Serge Semin
On Sun, Sep 06, 2020 at 06:18:07AM +, Dingtianhong wrote: [...] > > On Sat, Aug 22, 2020 at 12:27:53PM +0800, Ding Tianhong wrote: > >> The hisilicon ascend soc's gpio is based on the synopsys DW gpio, > >> and expand the register to support for INTCOMB_MASK, the new > >> register is used to

Re: [PATCH] gpio: dwapb: add support for new hisilicon ascend soc

2020-08-28 Thread Bartosz Golaszewski
On Thu, Aug 27, 2020 at 10:20 AM Andy Shevchenko wrote: > > On Tue, Aug 25, 2020 at 12:58 PM Serge Semin wrote: > > On Sat, Aug 22, 2020 at 12:27:53PM +0800, Ding Tianhong wrote: > > > BTW Linus, could you take a look at my series? Andy and Rob have finished > > reviewing > > it almost a month

Re: [PATCH] gpio: dwapb: add support for new hisilicon ascend soc

2020-08-27 Thread Linus Walleij
On Thu, Aug 27, 2020 at 10:20 AM Andy Shevchenko wrote: > On Tue, Aug 25, 2020 at 12:58 PM Serge Semin wrote: > > On Sat, Aug 22, 2020 at 12:27:53PM +0800, Ding Tianhong wrote: > > > BTW Linus, could you take a look at my series? Andy and Rob have finished > > reviewing > > it almost a month

Re: [PATCH] gpio: dwapb: add support for new hisilicon ascend soc

2020-08-27 Thread Andy Shevchenko
On Tue, Aug 25, 2020 at 12:58 PM Serge Semin wrote: > On Sat, Aug 22, 2020 at 12:27:53PM +0800, Ding Tianhong wrote: > BTW Linus, could you take a look at my series? Andy and Rob have finished > reviewing > it almost a month ago. I was wondering the same, but in normal cases (not closer to the

Re: [PATCH] gpio: dwapb: add support for new hisilicon ascend soc

2020-08-25 Thread Serge Semin
Hello Ding, Thanks for the patch. My comments are below. On Sat, Aug 22, 2020 at 12:27:53PM +0800, Ding Tianhong wrote: > The hisilicon ascend soc's gpio is based on the synopsys DW gpio, > and expand the register to support for INTCOMB_MASK, the new > register is used to enable/disable the

[PATCH] gpio: dwapb: add support for new hisilicon ascend soc

2020-08-21 Thread Ding Tianhong
The hisilicon ascend soc's gpio is based on the synopsys DW gpio, and expand the register to support for INTCOMB_MASK, the new register is used to enable/disable the interrupt combine features. Both support for ACPI and Device Tree. Signed-off-by: Ding Tianhong --- drivers/gpio/gpio-dwapb.c |