Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-10-08 Thread Masahiro Yamada
2017-09-22 6:54 GMT+09:00 David Daney : > On 09/13/2017 07:37 PM, Masahiro Yamada wrote: >> >> This driver implements .alloc() hook, so .map() is not used. > > > Although this comment is true for this driver, it is unclear to me if the > statement is true in the general

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-10-08 Thread Masahiro Yamada
2017-09-22 6:54 GMT+09:00 David Daney : > On 09/13/2017 07:37 PM, Masahiro Yamada wrote: >> >> This driver implements .alloc() hook, so .map() is not used. > > > Although this comment is true for this driver, it is unclear to me if the > statement is true in the general case. If a driver

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-22 Thread Linus Walleij
On Thu, Sep 14, 2017 at 4:37 AM, Masahiro Yamada wrote: > This driver implements .alloc() hook, so .map() is not used. > > Signed-off-by: Masahiro Yamada Patch applied with David's Tested-by. Yours, Linus Walleij

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-22 Thread Linus Walleij
On Thu, Sep 14, 2017 at 4:37 AM, Masahiro Yamada wrote: > This driver implements .alloc() hook, so .map() is not used. > > Signed-off-by: Masahiro Yamada Patch applied with David's Tested-by. Yours, Linus Walleij

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-21 Thread David Daney
On 09/13/2017 07:37 PM, Masahiro Yamada wrote: This driver implements .alloc() hook, so .map() is not used. Although this comment is true for this driver, it is unclear to me if the statement is true in the general case. Signed-off-by: Masahiro Yamada

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-21 Thread David Daney
On 09/13/2017 07:37 PM, Masahiro Yamada wrote: This driver implements .alloc() hook, so .map() is not used. Although this comment is true for this driver, it is unclear to me if the statement is true in the general case. Signed-off-by: Masahiro Yamada Tested-by: David Daney ---

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-21 Thread Linus Walleij
On Thu, Sep 14, 2017 at 4:37 AM, Masahiro Yamada wrote: > This driver implements .alloc() hook, so .map() is not used. > > Signed-off-by: Masahiro Yamada Waiting for David to test this patch before applying. Yours, Linus Walleij

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-21 Thread Linus Walleij
On Thu, Sep 14, 2017 at 4:37 AM, Masahiro Yamada wrote: > This driver implements .alloc() hook, so .map() is not used. > > Signed-off-by: Masahiro Yamada Waiting for David to test this patch before applying. Yours, Linus Walleij

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-14 Thread Masahiro Yamada
Hi David, 2017-09-15 1:59 GMT+09:00 David Daney : > On 09/13/2017 07:37 PM, Masahiro Yamada wrote: >> >> This driver implements .alloc() hook, so .map() is not used. >> > > Have you tested this? No. I do not have access to this hardware. It is just, in my

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-14 Thread Masahiro Yamada
Hi David, 2017-09-15 1:59 GMT+09:00 David Daney : > On 09/13/2017 07:37 PM, Masahiro Yamada wrote: >> >> This driver implements .alloc() hook, so .map() is not used. >> > > Have you tested this? No. I do not have access to this hardware. It is just, in my understanding, .alloc() and .map()

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-14 Thread David Daney
On 09/13/2017 07:37 PM, Masahiro Yamada wrote: This driver implements .alloc() hook, so .map() is not used. Have you tested this? I will have to test this on a real system next week before I can really comment on it. David. Signed-off-by: Masahiro Yamada

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-14 Thread David Daney
On 09/13/2017 07:37 PM, Masahiro Yamada wrote: This driver implements .alloc() hook, so .map() is not used. Have you tested this? I will have to test this on a real system next week before I can really comment on it. David. Signed-off-by: Masahiro Yamada ---

[PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-13 Thread Masahiro Yamada
This driver implements .alloc() hook, so .map() is not used. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpio-thunderx.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c index

[PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-13 Thread Masahiro Yamada
This driver implements .alloc() hook, so .map() is not used. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpio-thunderx.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c index 57efb25..b5adb79 100644 ---