Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-17 Thread Linus Walleij
On Thu, Nov 5, 2015 at 8:38 PM, Dmitry Torokhov wrote: > We should not fall back to the legacy unnamed gpio lookup style if the > driver requests gpios with different names, because we'll give out the same > gpio twice. Let's keep track of the names that were used for the device and > only do

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-17 Thread Linus Walleij
On Thu, Nov 5, 2015 at 8:38 PM, Dmitry Torokhov wrote: > We should not fall back to the legacy unnamed gpio lookup style if the > driver requests gpios with different names, because we'll give out the same > gpio twice. Let's keep track of the names that were used for

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-06 Thread Mika Westerberg
On Fri, Nov 06, 2015 at 12:25:34AM -0800, Dmitry Torokhov wrote: > I wonder if I should move acpi_can_fallback_to_crs() into > gpiolib-acpi.c and provide a stub for it... That works too :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-06 Thread Dmitry Torokhov
On Fri, Nov 6, 2015 at 12:08 AM, Mika Westerberg wrote: > On Thu, Nov 05, 2015 at 11:38:38AM -0800, Dmitry Torokhov wrote: >> We should not fall back to the legacy unnamed gpio lookup style if the >> driver requests gpios with different names, because we'll give out the same >> gpio twice. Let's

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-06 Thread Mika Westerberg
On Thu, Nov 05, 2015 at 11:38:38AM -0800, Dmitry Torokhov wrote: > We should not fall back to the legacy unnamed gpio lookup style if the > driver requests gpios with different names, because we'll give out the same > gpio twice. Let's keep track of the names that were used for the device and >

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-06 Thread Mika Westerberg
On Thu, Nov 05, 2015 at 11:38:38AM -0800, Dmitry Torokhov wrote: > We should not fall back to the legacy unnamed gpio lookup style if the > driver requests gpios with different names, because we'll give out the same > gpio twice. Let's keep track of the names that were used for the device and >

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-06 Thread Dmitry Torokhov
On Fri, Nov 6, 2015 at 12:08 AM, Mika Westerberg wrote: > On Thu, Nov 05, 2015 at 11:38:38AM -0800, Dmitry Torokhov wrote: >> We should not fall back to the legacy unnamed gpio lookup style if the >> driver requests gpios with different names, because we'll give

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-06 Thread Mika Westerberg
On Fri, Nov 06, 2015 at 12:25:34AM -0800, Dmitry Torokhov wrote: > I wonder if I should move acpi_can_fallback_to_crs() into > gpiolib-acpi.c and provide a stub for it... That works too :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-05 Thread kbuild test robot
Hi Dmitry, [auto build test ERROR on: gpio/for-next] [also build test ERROR on: v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/gpiolib-tighten-up-ACPI-legacy-gpio-lookups/20151106-034359 base:

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-05 Thread kbuild test robot
Hi Dmitry, [auto build test ERROR on: gpio/for-next] [also build test ERROR on: v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/gpiolib-tighten-up-ACPI-legacy-gpio-lookups/20151106-034359 base:

[PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-05 Thread Dmitry Torokhov
We should not fall back to the legacy unnamed gpio lookup style if the driver requests gpios with different names, because we'll give out the same gpio twice. Let's keep track of the names that were used for the device and only do the fallback for the first name used. Also disable fallback to

[PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-05 Thread Dmitry Torokhov
We should not fall back to the legacy unnamed gpio lookup style if the driver requests gpios with different names, because we'll give out the same gpio twice. Let's keep track of the names that were used for the device and only do the fallback for the first name used. Also disable fallback to

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-05 Thread kbuild test robot
Hi Dmitry, [auto build test ERROR on: gpio/for-next] [also build test ERROR on: v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/gpiolib-tighten-up-ACPI-legacy-gpio-lookups/20151106-034359 base:

Re: [PATCH] gpiolib: tighten up ACPI legacy gpio lookups

2015-11-05 Thread kbuild test robot
Hi Dmitry, [auto build test ERROR on: gpio/for-next] [also build test ERROR on: v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/gpiolib-tighten-up-ACPI-legacy-gpio-lookups/20151106-034359 base: