Re: [PATCH] gpu/drm/bridge/sii9234: Use common error handling code in sii9234_writebm()

2017-10-23 Thread SF Markus Elfring
>> ret = i2c_smbus_write_byte_data(client, offset, value); >> -if (ret < 0) { >> -dev_err(ctx->dev, "writebm: %4s[0x%02x] <- 0x%02x\n", >> -sii9234_client_name[id], offset, value); >> -ctx->i2c_error = ret; >> -} >> +if (!ret) >> +

Re: [PATCH] gpu/drm/bridge/sii9234: Use common error handling code in sii9234_writebm()

2017-10-23 Thread SF Markus Elfring
>> ret = i2c_smbus_write_byte_data(client, offset, value); >> -if (ret < 0) { >> -dev_err(ctx->dev, "writebm: %4s[0x%02x] <- 0x%02x\n", >> -sii9234_client_name[id], offset, value); >> -ctx->i2c_error = ret; >> -} >> +if (!ret) >> +

Re: [PATCH] gpu/drm/bridge/sii9234: Use common error handling code in sii9234_writebm()

2017-10-23 Thread Dan Carpenter
On Sun, Oct 22, 2017 at 09:32:46PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Oct 2017 21:21:44 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was

Re: [PATCH] gpu/drm/bridge/sii9234: Use common error handling code in sii9234_writebm()

2017-10-23 Thread Dan Carpenter
On Sun, Oct 22, 2017 at 09:32:46PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Oct 2017 21:21:44 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using the

[PATCH] gpu/drm/bridge/sii9234: Use common error handling code in sii9234_writebm()

2017-10-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 22 Oct 2017 21:21:44 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. * Adjust condition checks.

[PATCH] gpu/drm/bridge/sii9234: Use common error handling code in sii9234_writebm()

2017-10-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 22 Oct 2017 21:21:44 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. * Adjust condition checks. Signed-off-by: Markus Elfring ---