Re: [PATCH] hugetlbfs: make BUG_ON(!inode) takes effect in hugetlbfs_setattr

2021-01-18 Thread Miaohe Lin
Hi: On 2021/1/18 15:59, Muchun Song wrote: > On Sat, Jan 16, 2021 at 5:11 PM Miaohe Lin wrote: >> >> When we reach here with inode = NULL, we should have crashed as inode has >> already been dereferenced via hstate_inode. In order to make BUG_ON(!inode) >> takes effect, we should defer

Re: [PATCH] hugetlbfs: make BUG_ON(!inode) takes effect in hugetlbfs_setattr

2021-01-18 Thread Muchun Song
On Sat, Jan 16, 2021 at 5:11 PM Miaohe Lin wrote: > > When we reach here with inode = NULL, we should have crashed as inode has > already been dereferenced via hstate_inode. In order to make BUG_ON(!inode) > takes effect, we should defer initializing hstate until we really need it. > Also do this

[PATCH] hugetlbfs: make BUG_ON(!inode) takes effect in hugetlbfs_setattr

2021-01-16 Thread Miaohe Lin
When we reach here with inode = NULL, we should have crashed as inode has already been dereferenced via hstate_inode. In order to make BUG_ON(!inode) takes effect, we should defer initializing hstate until we really need it. Also do this for hugetlbfs_inode_info as it's only used when ia_valid is