Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Dec 19, 2017 at 11:14:03PM +0530, Selvin Xavier wrote: > On Tue, Dec 19, 2017 at 6:00 PM, Leon Romanovsky wrote: > >> status = ocrdma_nonemb_mbx_cmd(dev, mqe, dev->stats_mem.va); > > > > It still doesn't make a lot of sense to me: > > > > ocrdma_mbx_rdma_stats(): > > 1315

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Dec 19, 2017 at 11:14:03PM +0530, Selvin Xavier wrote: > On Tue, Dec 19, 2017 at 6:00 PM, Leon Romanovsky wrote: > >> status = ocrdma_nonemb_mbx_cmd(dev, mqe, dev->stats_mem.va); > > > > It still doesn't make a lot of sense to me: > > > > ocrdma_mbx_rdma_stats(): > > 1315if

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Dec 19, 2017 at 6:00 PM, Leon Romanovsky wrote: >> status = ocrdma_nonemb_mbx_cmd(dev, mqe, dev->stats_mem.va); > > It still doesn't make a lot of sense to me: > > ocrdma_mbx_rdma_stats(): > 1315if (reset) > 1316 req->reset_stats = reset; > 1317 >

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Dec 19, 2017 at 6:00 PM, Leon Romanovsky wrote: >> status = ocrdma_nonemb_mbx_cmd(dev, mqe, dev->stats_mem.va); > > It still doesn't make a lot of sense to me: > > ocrdma_mbx_rdma_stats(): > 1315if (reset) > 1316 req->reset_stats = reset; > 1317 > 1318

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Dec 19, 2017 at 03:59:30PM +0530, Selvin Xavier wrote: > On Wed, Aug 16, 2017 at 12:01 AM, Leon Romanovsky wrote: > > On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: > >> Debugfs file reset_stats is created with S_IRUSR permissions, > >> but

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Dec 19, 2017 at 03:59:30PM +0530, Selvin Xavier wrote: > On Wed, Aug 16, 2017 at 12:01 AM, Leon Romanovsky wrote: > > On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: > >> Debugfs file reset_stats is created with S_IRUSR permissions, > >> but ocrdma_dbgfs_ops_read() doesn't

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Wed, Aug 16, 2017 at 12:01 AM, Leon Romanovsky wrote: > On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: >> Debugfs file reset_stats is created with S_IRUSR permissions, >> but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, >> whereas

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Wed, Aug 16, 2017 at 12:01 AM, Leon Romanovsky wrote: > On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: >> Debugfs file reset_stats is created with S_IRUSR permissions, >> but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, >> whereas ocrdma_dbgfs_ops_write()

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: > Debugfs file reset_stats is created with S_IRUSR permissions, > but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, > whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS. > > The patch fixes misstype with

Re: [PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: > Debugfs file reset_stats is created with S_IRUSR permissions, > but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, > whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS. > > The patch fixes misstype with

[PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

Debugfs file reset_stats is created with S_IRUSR permissions, but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS. The patch fixes misstype with permissions. Found by Linux Driver Verification project

[PATCH] hw: Fix permissions for OCRDMA_RESET_STATS

Debugfs file reset_stats is created with S_IRUSR permissions, but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS. The patch fixes misstype with permissions. Found by Linux Driver Verification project