On Wed, 2018-05-09 at 11:50 +0800, Lei YU wrote:
> On Wed, May 9, 2018 at 11:43 AM, Guenter Roeck wrote:
> >
> > I am not going to accept this change, period. This is not one, it is five
> > steps
> > backward. If "aspeed_set_clock_source(priv->regmap, 0)" changes the clock
> > speed,
> > or the
On Wed, May 9, 2018 at 11:43 AM, Guenter Roeck wrote:
>
> I am not going to accept this change, period. This is not one, it is five
> steps
> backward. If "aspeed_set_clock_source(priv->regmap, 0)" changes the clock
> speed,
> or the clock source, read it later, and attach to the correct clock. If
On 05/08/2018 08:18 PM, Lei YU wrote:
On Tue, May 8, 2018 at 9:51 PM, Guenter Roeck wrote:
No mixed C/C++ comments in hwmon drivers.
aspeed_set_clock_source(priv->regmap, 0);
+ priv->clk_freq = 2400;
Are you saying that clk_get_rate() is wrong ? Anyway, if the DT is bad
On Tue, May 8, 2018 at 9:51 PM, Guenter Roeck wrote:
> No mixed C/C++ comments in hwmon drivers.
>
>> aspeed_set_clock_source(priv->regmap, 0);
>> + priv->clk_freq = 2400;
>>
>
>
> Are you saying that clk_get_rate() is wrong ? Anyway, if the DT is bad, it
> should be fixed.
Nope,
On 05/08/2018 02:39 AM, Lei YU wrote:
The clock source for aspeed pwm is set to 24MHz, so use the hard-coded
clock frequency instead of the one in device tree.
Otherwise, in case of the clock specified in device tree is not 24MHz,
the fan speed will be incorrect.
Signed-off-by: Lei YU
---
dr
The clock source for aspeed pwm is set to 24MHz, so use the hard-coded
clock frequency instead of the one in device tree.
Otherwise, in case of the clock specified in device tree is not 24MHz,
the fan speed will be incorrect.
Signed-off-by: Lei YU
---
drivers/hwmon/aspeed-pwm-tacho.c | 7 ++
6 matches
Mail list logo
