Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-07-01 Thread Andi Kleen
> > --- a/mm/memory-failure.c > > +++ b/mm/memory-failure.c > > @@ -1168,6 +1168,16 @@ int memory_failure(unsigned long pfn, int trapno, > > int flags) > > lock_page(hpage); > > > > /* > > +* The page could have changed compound pages during the locking. > > +* If this happens

Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-07-01 Thread Andrew Morton
On Mon, 30 Jun 2014 17:32:16 -0700 Andi Kleen wrote: > From: Andi Kleen > > When a hwpoison page is locked it could change state > due to parallel modifications. Check after the lock > if the page is still the same compound page. > > ... > > --- a/mm/memory-failure.c > +++

Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-07-01 Thread Andrew Morton
On Mon, 30 Jun 2014 17:32:16 -0700 Andi Kleen a...@firstfloor.org wrote: From: Andi Kleen a...@linux.intel.com When a hwpoison page is locked it could change state due to parallel modifications. Check after the lock if the page is still the same compound page. ... ---

Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-07-01 Thread Andi Kleen
--- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1168,6 +1168,16 @@ int memory_failure(unsigned long pfn, int trapno, int flags) lock_page(hpage); /* +* The page could have changed compound pages during the locking. +* If this happens just bail out. +

Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-06-30 Thread Andi Kleen
> Acked-by: Naoya Horiguchi > > Is it -stable matter? > Maybe 2.6.38+ can profit from this. Probably not, it's not a critical bug fix. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-06-30 Thread Naoya Horiguchi
On Mon, Jun 30, 2014 at 05:32:16PM -0700, Andi Kleen wrote: > From: Andi Kleen > > When a hwpoison page is locked it could change state > due to parallel modifications. Check after the lock > if the page is still the same compound page. > > [v2: Removed earlier non LRU check which should be

[PATCH] hwpoison: Fix race with changing page during offlining v2

2014-06-30 Thread Andi Kleen
From: Andi Kleen When a hwpoison page is locked it could change state due to parallel modifications. Check after the lock if the page is still the same compound page. [v2: Removed earlier non LRU check which should be already covered elsewhere] Cc: Naoya Horiguchi Signed-off-by: Andi Kleen

[PATCH] hwpoison: Fix race with changing page during offlining v2

2014-06-30 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com When a hwpoison page is locked it could change state due to parallel modifications. Check after the lock if the page is still the same compound page. [v2: Removed earlier non LRU check which should be already covered elsewhere] Cc: Naoya Horiguchi

Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-06-30 Thread Naoya Horiguchi
On Mon, Jun 30, 2014 at 05:32:16PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com When a hwpoison page is locked it could change state due to parallel modifications. Check after the lock if the page is still the same compound page. [v2: Removed earlier non LRU check which

Re: [PATCH] hwpoison: Fix race with changing page during offlining v2

2014-06-30 Thread Andi Kleen
Acked-by: Naoya Horiguchi n-horigu...@ah.jp.nec.com Is it -stable matter? Maybe 2.6.38+ can profit from this. Probably not, it's not a critical bug fix. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More