Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-11 Thread Florian Fainelli
On 3/4/2021 10:26 PM, Álvaro Fernández Rojas wrote: > Hi Florian, > >> El 4 mar 2021, a las 23:28, Florian Fainelli escribió: >> >> On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote: >>> On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote: Hi Herbert, > El 3 mar 2021,

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-04 Thread Álvaro Fernández Rojas
Hi Florian, > El 4 mar 2021, a las 23:28, Florian Fainelli escribió: > > On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote: >> On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote: >>> Hi Herbert, >>> El 3 mar 2021, a las 10:20, Herbert Xu escribió: On Sat, Feb

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-04 Thread Florian Fainelli
On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote: > On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote: >> Hi Herbert, >> >>> El 3 mar 2021, a las 10:20, Herbert Xu >>> escribió: >>> >>> On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote: I ran rngtest

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-04 Thread Nicolas Saenz Julienne
On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote: > Hi Herbert, > > > El 3 mar 2021, a las 10:20, Herbert Xu > > escribió: > > > > On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote: > > > > > > I ran rngtest and this is what I got: > > > > This is

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-03 Thread Herbert Xu
On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote: > > I ran rngtest and this is what I got: This is meaningless except for sources that have not been whitened. Your justification needs to be based on what the hardware does or is documented to do. Thanks, -- Email:

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-03-03 Thread Álvaro Fernández Rojas
Hi Herbert, > El 3 mar 2021, a las 10:20, Herbert Xu escribió: > > On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote: >> >> I ran rngtest and this is what I got: > > This is meaningless except for sources that have not been whitened. > > Your justification needs to be

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-02-20 Thread Andrew Lunn
On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote: > Hi Andrew, > > I ran rngtest and this is what I got: > root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000 > rngtest 6.10 > Copyright (c) 2004 by Henrique de Moraes Holschuh > This is free software; see the source for copying

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-02-20 Thread Álvaro Fernández Rojas
Hi Andrew, I ran rngtest and this is what I got: root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000 rngtest 6.10 Copyright (c) 2004 by Henrique de Moraes Holschuh This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A

Re: [PATCH] hwrng: bcm2835: set quality to 1000

2021-02-20 Thread Andrew Lunn
On Sat, Feb 20, 2021 at 06:47:40PM +0100, Álvaro Fernández Rojas wrote: > This allows devices without a high precission timer to reduce boot from >100s > to <30s. > diff --git a/drivers/char/hw_random/bcm2835-rng.c > b/drivers/char/hw_random/bcm2835-rng.c > index 1a7c43b43c6b..4b48cb7176b0 100644

[PATCH] hwrng: bcm2835: set quality to 1000

2021-02-20 Thread Álvaro Fernández Rojas
This allows devices without a high precission timer to reduce boot from >100s to <30s. Signed-off-by: Álvaro Fernández Rojas --- drivers/char/hw_random/bcm2835-rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c