Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-11-30 Thread Qinglang Miao
在 2020/11/27 22:26, Lukasz Stelmach 写道: It was <2020-11-27 pią 17:44>, when Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in

Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-11-30 Thread Qinglang Miao
在 2020/11/27 17:44, Krzysztof Kozlowski 写道: On Fri, Nov 27, 2020 at 05:44:46PM +0800, Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is int

Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-11-27 Thread Lukasz Stelmach
It was <2020-11-27 pią 17:44>, when Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is introduced in > [0] to keep usage counter balanced

Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-11-27 Thread Krzysztof Kozlowski
On Fri, Nov 27, 2020 at 05:44:46PM +0800, Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is introduced in > [0] to keep usage counter b

[PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-11-27 Thread Qinglang Miao
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep usage counter balanced. So We fix the reference leak by replacing it with new funtion. [0