Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-29 Thread Andy Shevchenko
On Mon, Mar 29, 2021 at 11:25:58AM +0530, Goswami, Sanket wrote: > On 26-Mar-21 16:10, Andy Shevchenko wrote: > > On Fri, Mar 26, 2021 at 03:53:34PM +0530, Goswami, Sanket wrote: > >> On 25-Mar-21 22:35, Andy Shevchenko wrote: > >>> On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote:

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-28 Thread Goswami, Sanket
Hi Andy, Thanks for the review. On 26-Mar-21 16:10, Andy Shevchenko wrote: > [CAUTION: External Email] > > On Fri, Mar 26, 2021 at 03:53:34PM +0530, Goswami, Sanket wrote: >> On 25-Mar-21 22:35, Andy Shevchenko wrote: >>> On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote: On

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-26 Thread Andy Shevchenko
On Fri, Mar 26, 2021 at 03:53:34PM +0530, Goswami, Sanket wrote: > On 25-Mar-21 22:35, Andy Shevchenko wrote: > > On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote: > >> On 09-Mar-21 19:56, Andy Shevchenko wrote: > >>> On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote:

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-26 Thread Goswami, Sanket
Hi Andy, On 25-Mar-21 22:35, Andy Shevchenko wrote: > [CAUTION: External Email] > > On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote: >> On 09-Mar-21 19:56, Andy Shevchenko wrote: >>> On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote: > > ... > +static int

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-25 Thread Andy Shevchenko
On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote: > On 09-Mar-21 19:56, Andy Shevchenko wrote: > > On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote: ... > >> +static int amd_i2c_dw_master_xfer(struct i2c_adapter *adap, struct > >> i2c_msg *msgs, int num_msgs) > > >

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-22 Thread Goswami, Sanket
Hi Andy, On 09-Mar-21 19:56, Andy Shevchenko wrote: > [CAUTION: External Email] > > On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote: > > i2c: -> i2c: designware: > add i2c bus driver -> add a driver > amd -> AMD > gpu -> GPU > > in the subject > >> Latest AMDGPU NAVI cards have

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-09 Thread kernel test robot
Hi Sanket, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on v5.12-rc2 next-20210309] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-09 Thread kernel test robot
Hi Sanket, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on v5.12-rc2 next-20210309] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-09 Thread Andy Shevchenko
On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote: i2c: -> i2c: designware: add i2c bus driver -> add a driver amd -> AMD gpu -> GPU in the subject > Latest AMDGPU NAVI cards have USB Type-C interface which can be accessed > over I2C. I didn't get this. You mean that USB traffic

Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-09 Thread kernel test robot
Hi Sanket, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on v5.12-rc2 next-20210309] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

[PATCH] i2c: add i2c bus driver for amd navi gpu

2021-03-09 Thread Sanket Goswami
Latest AMDGPU NAVI cards have USB Type-C interface which can be accessed over I2C. The Type-C controller has integrated designware i2c which is exposed as a PCI device to the AMD platform. Also there exists couple of notable IP problems that are dealt as a workaround: - I2C transactions work on a