Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-22 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 1:26 PM Doug Anderson wrote: > > Hi, > > On Tue, Jul 21, 2020 at 11:55 AM Stephen Boyd wrote: > > > > Quoting Doug Anderson (2020-07-21 09:18:35) > > > On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > > > > > > > Quoting Stephen Boyd (2020-07-20 22:59:14) >

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 11:55 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-07-21 09:18:35) > > On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > > > > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > > > > > I worry that we also need a dmb() here to make sure the dma

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Stephen Boyd
Quoting Doug Anderson (2020-07-21 09:18:35) > On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > > > I worry that we also need a dmb() here to make sure the dma buffer is > > > properly mapped before this write to the device is

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > I worry that we also need a dmb() here to make sure the dma buffer is > > properly mapped before this write to the device is attempted. But it may > > only matter to be before the

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Mukesh, Savaliya
On 7/21/2020 12:37 PM, Stephen Boyd wrote: Quoting Stephen Boyd (2020-07-20 22:59:14) I worry that we also need a dmb() here to make sure the dma buffer is properly mapped before this write to the device is attempted. But it may only matter to be before the I2C_READ. I'm suggesting this

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Akash Asthana
On 7/21/2020 5:54 AM, Douglas Anderson wrote: When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Stephen Boyd
Quoting Stephen Boyd (2020-07-20 22:59:14) > > I worry that we also need a dmb() here to make sure the dma buffer is > properly mapped before this write to the device is attempted. But it may > only matter to be before the I2C_READ. > I'm suggesting this patch instead where we make

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Stephen Boyd
Quoting Douglas Anderson (2020-07-20 17:24:53) > When I have KASAN enabled on my kernel and I start stressing the > touchscreen my system tends to hang. The touchscreen is one of the > only things that does a lot of big i2c transfers and ends up hitting > the DMA paths in the geni i2c driver. It

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Sai Prakash Ranjan
On 2020-07-21 05:54, Douglas Anderson wrote: When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It appears

[PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Douglas Anderson
When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It appears that KASAN adds enough delay in my system to