Re: [PATCH] i2c: muxes: pca9541: use BIT() macro

2019-09-05 Thread Guenter Roeck
On Thu, Sep 05, 2019 at 09:15:36PM +0530, Saiyam Doshi wrote: > On Thu, Sep 05, 2019 at 06:21:06AM -0700, Guenter Roeck wrote: > > linux/bitops.h should be included when using BIT(). > > It's included from linux/i2c-mux.h and it compiled successfully. > But if it's needed I'll update the patch

Re: [PATCH] i2c: muxes: pca9541: use BIT() macro

2019-09-05 Thread Saiyam Doshi
On Thu, Sep 05, 2019 at 06:21:06AM -0700, Guenter Roeck wrote: > linux/bitops.h should be included when using BIT(). It's included from linux/i2c-mux.h and it compiled successfully. But if it's needed I'll update the patch and resend. Just a question - What is the best practice in such case?

Re: [PATCH] i2c: muxes: pca9541: use BIT() macro

2019-09-05 Thread Guenter Roeck
On 9/5/19 6:13 AM, Saiyam Doshi wrote: Use bit mask macro BIT() for definition where appropriate. Signed-off-by: Saiyam Doshi linux/bitops.h should be included when using BIT(). Guenter --- drivers/i2c/muxes/i2c-mux-pca9541.c | 28 ++-- 1 file changed, 14

[PATCH] i2c: muxes: pca9541: use BIT() macro

2019-09-05 Thread Saiyam Doshi
Use bit mask macro BIT() for definition where appropriate. Signed-off-by: Saiyam Doshi --- drivers/i2c/muxes/i2c-mux-pca9541.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c