Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-13 Thread Wolfram Sang
On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: > AMD Family 17h uses the KERNCZ SMBus controller. While its documentation > is not publicly available, it is documented in the BIOS and Kernel > Developer’s Guide for AMD Family 15h Models 60h-6Fh Processors. > > On this SMBus

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-13 Thread Wolfram Sang
On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: > AMD Family 17h uses the KERNCZ SMBus controller. While its documentation > is not publicly available, it is documented in the BIOS and Kernel > Developer’s Guide for AMD Family 15h Models 60h-6Fh Processors. > > On this SMBus

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-06 Thread Guenter Roeck
On Thu, Oct 05, 2017 at 08:34:01PM +0200, Rudolf Marek wrote: > Hi Guys, > > Even in "AMD Family 15h Models 60h-6Fh Processors" [1] > are ports3 and ports4 marked as "Reserved". Maybe we should limit "KERN" to 2 > ports? > Maybe, if we are sure that this applies to all CPU models supported by

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-06 Thread Guenter Roeck
On Thu, Oct 05, 2017 at 08:34:01PM +0200, Rudolf Marek wrote: > Hi Guys, > > Even in "AMD Family 15h Models 60h-6Fh Processors" [1] > are ports3 and ports4 marked as "Reserved". Maybe we should limit "KERN" to 2 > ports? > Maybe, if we are sure that this applies to all CPU models supported by

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Rudolf Marek
Hi Guys, Even in "AMD Family 15h Models 60h-6Fh Processors" [1] are ports3 and ports4 marked as "Reserved". Maybe we should limit "KERN" to 2 ports? Thanks Rudolf [1] http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Rudolf Marek
Hi Guys, Even in "AMD Family 15h Models 60h-6Fh Processors" [1] are ports3 and ports4 marked as "Reserved". Maybe we should limit "KERN" to 2 ports? Thanks Rudolf [1] http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Guenter Roeck
On Thu, Oct 05, 2017 at 05:11:15PM +0200, Wolfram Sang wrote: > > > Sorry for the delay. Looks all good to me (as I'd expect from Gunter...) > > > > Reviewed-by: Jean Delvare > > Thanks, Jean! > > Guenter: I will queue it to for-current, when I am back home. Does it > need a

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Guenter Roeck
On Thu, Oct 05, 2017 at 05:11:15PM +0200, Wolfram Sang wrote: > > > Sorry for the delay. Looks all good to me (as I'd expect from Gunter...) > > > > Reviewed-by: Jean Delvare > > Thanks, Jean! > > Guenter: I will queue it to for-current, when I am back home. Does it > need a stable tag? > I

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Wolfram Sang
> Sorry for the delay. Looks all good to me (as I'd expect from Gunter...) > > Reviewed-by: Jean Delvare Thanks, Jean! Guenter: I will queue it to for-current, when I am back home. Does it need a stable tag? Regards, Wolfram signature.asc Description: PGP signature

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Wolfram Sang
> Sorry for the delay. Looks all good to me (as I'd expect from Gunter...) > > Reviewed-by: Jean Delvare Thanks, Jean! Guenter: I will queue it to for-current, when I am back home. Does it need a stable tag? Regards, Wolfram signature.asc Description: PGP signature

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Jean Delvare
On Sat, 12 Aug 2017 13:33:57 +0200, Wolfram Sang wrote: > On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: > > AMD Family 17h uses the KERNCZ SMBus controller. While its documentation > > is not publicly available, it is documented in the BIOS and Kernel > > Developer’s Guide for AMD

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Jean Delvare
On Sat, 12 Aug 2017 13:33:57 +0200, Wolfram Sang wrote: > On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: > > AMD Family 17h uses the KERNCZ SMBus controller. While its documentation > > is not publicly available, it is documented in the BIOS and Kernel > > Developer’s Guide for AMD

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-09-22 Thread Guenter Roeck
On 08/12/2017 04:33 AM, Wolfram Sang wrote: On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: AMD Family 17h uses the KERNCZ SMBus controller. While its documentation is not publicly available, it is documented in the BIOS and Kernel Developer’s Guide for AMD Family 15h Models

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-09-22 Thread Guenter Roeck
On 08/12/2017 04:33 AM, Wolfram Sang wrote: On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: AMD Family 17h uses the KERNCZ SMBus controller. While its documentation is not publicly available, it is documented in the BIOS and Kernel Developer’s Guide for AMD Family 15h Models

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-08-12 Thread Wolfram Sang
On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: > AMD Family 17h uses the KERNCZ SMBus controller. While its documentation > is not publicly available, it is documented in the BIOS and Kernel > Developer’s Guide for AMD Family 15h Models 60h-6Fh Processors. > > On this SMBus

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-08-12 Thread Wolfram Sang
On Sat, Jul 15, 2017 at 04:51:26PM -0700, Guenter Roeck wrote: > AMD Family 17h uses the KERNCZ SMBus controller. While its documentation > is not publicly available, it is documented in the BIOS and Kernel > Developer’s Guide for AMD Family 15h Models 60h-6Fh Processors. > > On this SMBus

[PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-07-15 Thread Guenter Roeck
AMD Family 17h uses the KERNCZ SMBus controller. While its documentation is not publicly available, it is documented in the BIOS and Kernel Developer’s Guide for AMD Family 15h Models 60h-6Fh Processors. On this SMBus controller, the port select register is at PMx register 0x02, bit 4:3 (PMx00

[PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-07-15 Thread Guenter Roeck
AMD Family 17h uses the KERNCZ SMBus controller. While its documentation is not publicly available, it is documented in the BIOS and Kernel Developer’s Guide for AMD Family 15h Models 60h-6Fh Processors. On this SMBus controller, the port select register is at PMx register 0x02, bit 4:3 (PMx00