Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-05-05 Thread Uwe Kleine-König
Hello, On Mon, May 04, 2015 at 09:38:28AM -0700, Doug Anderson wrote: > On Mon, May 4, 2015 at 8:24 AM, Uwe Kleine-König > wrote: > >> Thank you for looking at this! I will clarify by giving explicit CPU > >> numbers (this issue can only happen in SMP, I think): > >> > >> 1. CPU1 is running rk3x

Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-05-04 Thread Doug Anderson
Hi, On Mon, May 4, 2015 at 8:24 AM, Uwe Kleine-König wrote: >> Thank you for looking at this! I will clarify by giving explicit CPU >> numbers (this issue can only happen in SMP, I think): >> >> 1. CPU1 is running rk3x_i2c_xfer() >> >> 2. CPU0 calls vprintk_emit(), which disables all IRQs on CPU

Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-05-04 Thread Uwe Kleine-König
Hello Doug, On Mon, May 04, 2015 at 08:11:10AM -0700, Doug Anderson wrote: > On Mon, May 4, 2015 at 1:33 AM, Uwe Kleine-König > wrote: > > On Thu, Apr 30, 2015 at 02:44:07PM -0700, Doug Anderson wrote: > >> While it's not sensible for an i2c command to _actually_ need more > >> than 200ms to comp

Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-05-04 Thread Doug Anderson
Uwe, On Mon, May 4, 2015 at 1:33 AM, Uwe Kleine-König wrote: > On Thu, Apr 30, 2015 at 02:44:07PM -0700, Doug Anderson wrote: >> While it's not sensible for an i2c command to _actually_ need more >> than 200ms to complete, let's increase the timeout anyway. Why? It >> turns out that if you've g

Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-05-04 Thread Uwe Kleine-König
On Thu, Apr 30, 2015 at 02:44:07PM -0700, Doug Anderson wrote: > While it's not sensible for an i2c command to _actually_ need more > than 200ms to complete, let's increase the timeout anyway. Why? It > turns out that if you've got a large number of printks going out to a > serial console, interr

Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-04-30 Thread Caesar Wang
在 2015年05月01日 05:44, Doug Anderson 写道: While it's not sensible for an i2c command to _actually_ need more than 200ms to complete, let's increase the timeout anyway. Why? It turns out that if you've got a large number of printks going out to a serial console, interrupts on a CPU can be disable

Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-04-30 Thread Caesar Wang
在 2015年05月01日 05:44, Doug Anderson 写道: While it's not sensible for an i2c command to _actually_ need more than 200ms to complete, let's increase the timeout anyway. Why? It turns out that if you've got a large number of printks going out to a serial console, interrupts on a CPU can be disable

[PATCH] i2c: rk3x: Increase wait timeout to 1 second

2015-04-30 Thread Doug Anderson
While it's not sensible for an i2c command to _actually_ need more than 200ms to complete, let's increase the timeout anyway. Why? It turns out that if you've got a large number of printks going out to a serial console, interrupts on a CPU can be disabled for hundreds of milliseconds. That's not