Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-17 Thread Josef Ahmad
>> Applied to for-current, thanks! > > Added stable, too. > Thanks Wolfram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-17 Thread Wolfram Sang
> Applied to for-current, thanks! Added stable, too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-17 Thread Wolfram Sang
On Wed, May 08, 2013 at 02:34:36PM +0100, Josef Ahmad wrote: > From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 > From: Josef Ahmad > Date: Fri, 19 Apr 2013 17:28:10 +0100 > Subject: [PATCH] i2c-designware: fix RX FIFO overrun > > i2c_dw_xfer_msg() pushes

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-17 Thread Wolfram Sang
On Wed, May 08, 2013 at 02:34:36PM +0100, Josef Ahmad wrote: From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-17 Thread Wolfram Sang
Applied to for-current, thanks! Added stable, too. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-17 Thread Josef Ahmad
Applied to for-current, thanks! Added stable, too. Thanks Wolfram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-08 Thread Josef Ahmad
>From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 From: Josef Ahmad Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus into the TX FIFO. For master

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-08 Thread Josef Ahmad
Sorry for late reply. Bad UA configuration. Will resend straight away. Thanks, Josef On Thu, 25 Apr 2013, Wolfram Sang wrote: > > Still can't apply :( Whitespace problems in the patch context :( > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-08 Thread Josef Ahmad
Sorry for late reply. Bad UA configuration. Will resend straight away. Thanks, Josef On Thu, 25 Apr 2013, Wolfram Sang wrote: Still can't apply :( Whitespace problems in the patch context :( -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-05-08 Thread Josef Ahmad
From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-25 Thread Wolfram Sang
On Wed, Apr 24, 2013 at 11:11:38AM +0100, Josef Ahmad wrote: > From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 > From: Josef Ahmad > Date: Fri, 19 Apr 2013 17:28:10 +0100 > Subject: [PATCH] i2c-designware: fix RX FIFO overrun > > i2c_dw_xfer_msg() pushes

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-25 Thread Wolfram Sang
On Wed, Apr 24, 2013 at 11:11:38AM +0100, Josef Ahmad wrote: From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-24 Thread Josef Ahmad
From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 From: Josef Ahmad Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus into the TX FIFO. For master-rx

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-24 Thread Josef Ahmad
From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-23 Thread Wolfram Sang
> > This driver had a major cleanup meanwhile. Could you rebase your patch > > on top of my for-next branch? I guess this version should make it into > > stable? > > > > This patch applies just fine on top of your i2c-embedded/for-next branch. i2c-embedded? Ah, this one is outdated. Please

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-23 Thread Josef Ahmad
> On Mon, Apr 22, 2013 at 03:08:59PM +0100, Josef Ahmad wrote: >> From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 >> From: Josef Ahmad >> Date: Fri, 19 Apr 2013 17:28:10 +0100 >> Subject: [PATCH] i2c-designware: fix RX FIFO overrun >> >

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-23 Thread Wolfram Sang
On Mon, Apr 22, 2013 at 03:08:59PM +0100, Josef Ahmad wrote: > From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 > From: Josef Ahmad > Date: Fri, 19 Apr 2013 17:28:10 +0100 > Subject: [PATCH] i2c-designware: fix RX FIFO overrun > > i2c_dw_xfer_msg() pushes

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-23 Thread Wolfram Sang
On Mon, Apr 22, 2013 at 03:08:59PM +0100, Josef Ahmad wrote: From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-23 Thread Josef Ahmad
On Mon, Apr 22, 2013 at 03:08:59PM +0100, Josef Ahmad wrote: From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-23 Thread Wolfram Sang
This driver had a major cleanup meanwhile. Could you rebase your patch on top of my for-next branch? I guess this version should make it into stable? This patch applies just fine on top of your i2c-embedded/for-next branch. i2c-embedded? Ah, this one is outdated. Please check

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Josef Ahmad
From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus into the TX FIFO. For master-rx

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Mika Westerberg
8:10 +0100 > >> Subject: [PATCH] i2c-designware: fix RX FIFO overrun > >> > >> i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive > >> to/from the bus into the TX FIFO. > >> For master-rx transactions, the maximum amount of dat

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Josef Ahmad
> On Fri, Apr 19, 2013 at 07:05:30PM +0100, Josef Ahmad wrote: >> >From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 >> From: Josef Ahmad >> Date: Fri, 19 Apr 2013 17:28:10 +0100 >> Subject: [PATCH] i2c-designware: fix RX FIFO overrun >>

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Mika Westerberg
On Fri, Apr 19, 2013 at 07:05:30PM +0100, Josef Ahmad wrote: > >From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 > From: Josef Ahmad > Date: Fri, 19 Apr 2013 17:28:10 +0100 > Subject: [PATCH] i2c-designware: fix RX FIFO overrun > > i2c_dw_xfer_msg() pus

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Mika Westerberg
On Fri, Apr 19, 2013 at 07:05:30PM +0100, Josef Ahmad wrote: From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Josef Ahmad
On Fri, Apr 19, 2013 at 07:05:30PM +0100, Josef Ahmad wrote: From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Mika Westerberg
: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus into the TX FIFO. For master-rx transactions, the maximum amount of data that can be received is calculated depending solely on TX and RX FIFO load. This is racy

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Josef Ahmad
From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-19 Thread Josef Ahmad
It does. The bug appears with fairly-sized read transactions (in the order of kB) returning corrupted data. Josef > Josef. > > This fixes a real bug for us does it not, some failure case with a > sustained amount of traffic ? > > > Bryan > > -- To unsubscribe from this list: send the line

[PATCH] i2c-designware: fix RX FIFO overrun

2013-04-19 Thread Josef Ahmad
From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus into the TX FIFO. For master-rx

[PATCH] i2c-designware: fix RX FIFO overrun

2013-04-19 Thread Josef Ahmad
From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive to/from the bus

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-19 Thread Josef Ahmad
It does. The bug appears with fairly-sized read transactions (in the order of kB) returning corrupted data. Josef Josef. This fixes a real bug for us does it not, some failure case with a sustained amount of traffic ? Bryan -- To unsubscribe from this list: send the line unsubscribe