RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-13 Thread Brown, Aaron F
nel.org; linux- > ker...@vger.kernel.org; kernel-janit...@vger.kernel.org; Christophe > JAILLET <christophe.jail...@wanadoo.fr> > Subject: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON > > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should b

RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-13 Thread Brown, Aaron F
.org; kernel-janit...@vger.kernel.org; Christophe > JAILLET > Subject: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON > > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is > 1 > and no other possible v

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Richard Cochran
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Richard Cochran
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more

[PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Christophe JAILLET
'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. The modified code should behave the same, because HWTSTAMP_TX_ON is 1 and no other possible values of 'tx_type' would match the test. However, this is more future-proof, should other values be allowed one day. See 'struct

[PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Christophe JAILLET
'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. The modified code should behave the same, because HWTSTAMP_TX_ON is 1 and no other possible values of 'tx_type' would match the test. However, this is more future-proof, should other values be allowed one day. See 'struct