Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-29 Thread Michael Hennerich
On 23.03.2017 12:05, Lars-Peter Clausen wrote: Sorry - I missed some of this review feedback ... + +static int ltc2497_wait_conv(struct ltc2497_st *st) +{ + s64 time_elapsed; + + time_elapsed = ktime_ms_delta(ktime_get(), st->time_prev); + + if (time_elapsed <

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-29 Thread Michael Hennerich
On 23.03.2017 12:05, Lars-Peter Clausen wrote: Sorry - I missed some of this review feedback ... + +static int ltc2497_wait_conv(struct ltc2497_st *st) +{ + s64 time_elapsed; + + time_elapsed = ktime_ms_delta(ktime_get(), st->time_prev); + + if (time_elapsed <

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread Michael Hennerich
On 23.03.2017 12:28, Peter Meerwald-Stadler wrote: On Thu, 23 Mar 2017, michael.henner...@analog.com wrote: From: Michael Hennerich comments below Hi Peter, Thanks for the review - comments inline. Signed-off-by: Michael Hennerich

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread Michael Hennerich
On 23.03.2017 12:28, Peter Meerwald-Stadler wrote: On Thu, 23 Mar 2017, michael.henner...@analog.com wrote: From: Michael Hennerich comments below Hi Peter, Thanks for the review - comments inline. Signed-off-by: Michael Hennerich --- .../devicetree/bindings/iio/adc/ltc2497.txt

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread Peter Meerwald-Stadler
On Thu, 23 Mar 2017, michael.henner...@analog.com wrote: > From: Michael Hennerich comments below > Signed-off-by: Michael Hennerich > --- > .../devicetree/bindings/iio/adc/ltc2497.txt| 13 + > MAINTAINERS

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread Peter Meerwald-Stadler
On Thu, 23 Mar 2017, michael.henner...@analog.com wrote: > From: Michael Hennerich comments below > Signed-off-by: Michael Hennerich > --- > .../devicetree/bindings/iio/adc/ltc2497.txt| 13 + > MAINTAINERS| 1 + > drivers/iio/adc/Kconfig

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread Lars-Peter Clausen
The subject should follow the standard subsystem subject scheme. E.g. in this case "iio: adc: Add driver for ..." On 03/23/2017 11:35 AM, michael.henner...@analog.com wrote: > From: Michael Hennerich Needs a commit message. > > Signed-off-by: Michael Hennerich

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread Lars-Peter Clausen
The subject should follow the standard subsystem subject scheme. E.g. in this case "iio: adc: Add driver for ..." On 03/23/2017 11:35 AM, michael.henner...@analog.com wrote: > From: Michael Hennerich Needs a commit message. > > Signed-off-by: Michael Hennerich > --- >

[PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread michael.hennerich
From: Michael Hennerich Signed-off-by: Michael Hennerich --- .../devicetree/bindings/iio/adc/ltc2497.txt| 13 + MAINTAINERS| 1 + drivers/iio/adc/Kconfig|

[PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

2017-03-23 Thread michael.hennerich
From: Michael Hennerich Signed-off-by: Michael Hennerich --- .../devicetree/bindings/iio/adc/ltc2497.txt| 13 + MAINTAINERS| 1 + drivers/iio/adc/Kconfig| 11 + drivers/iio/adc/Makefile |