Re: [PATCH] iio: adc: ad7292: remove unneeded spi_set_drvdata()

2020-11-21 Thread Jonathan Cameron
On Fri, 20 Nov 2020 11:21:58 -0300 Marcelo Schmitt wrote: > LGTM. > Tested on raspberry pi kernel - rpi-5.9.y. > > ad7292 was heavily based on ad7768-1. > Maybe this might apply to ad7768-1 as well. > > Reviewed-by: Marcelo Schmitt > Tested-by: Marcelo Schmitt Thanks, Applied to the togreg

Re: [PATCH] iio: adc: ad7292: remove unneeded spi_set_drvdata()

2020-11-20 Thread Marcelo Schmitt
LGTM. Tested on raspberry pi kernel - rpi-5.9.y. ad7292 was heavily based on ad7768-1. Maybe this might apply to ad7768-1 as well. Reviewed-by: Marcelo Schmitt Tested-by: Marcelo Schmitt On 11/19, Alexandru Ardelean wrote: > This seems to have been copied from a driver that calls

[PATCH] iio: adc: ad7292: remove unneeded spi_set_drvdata()

2020-11-19 Thread Alexandru Ardelean
This seems to have been copied from a driver that calls spi_set_drvdata() but doesn't call spi_get_drvdata(). Setting a private object on the SPI device's object isn't necessary if it won't be accessed. This change removes the spi_set_drvdata() call. Signed-off-by: Alexandru Ardelean ---