On Thu, 4 Jul 2019 21:55:58 +0200
Wolfram Sang wrote:
> > >> This is correct but missing that the above 'return ret' is broken, too.
> > >> ret is initialized but 0 in that case.
> > >
> > > Nice catch! Oh well, given enough eyeballs, ...
> >
> > I don't think ret is initialized, reg is,
> >> This is correct but missing that the above 'return ret' is broken, too.
> >> ret is initialized but 0 in that case.
> >
> > Nice catch! Oh well, given enough eyeballs, ...
>
> I don't think ret is initialized, reg is, not ret .
It is initialized for the broken 'return ret' *above* the one
On 7/4/19 2:10 PM, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang wrote:
>> On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
>>> gcc-9 complains about a blatant uninitialized variable use that
>>> all earlier compiler versions missed:
>>>
Hi Wolfram,
On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang wrote:
> On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
> > gcc-9 complains about a blatant uninitialized variable use that
> > all earlier compiler versions missed:
> >
> > drivers/iio/adc/rcar-gyroadc.c:510:5: warning:
On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
> gcc-9 complains about a blatant uninitialized variable use that
> all earlier compiler versions missed:
>
> drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>
Hi Arnd,
On Thu, Jul 4, 2019 at 1:38 PM Arnd Bergmann wrote:
> gcc-9 complains about a blatant uninitialized variable use that
> all earlier compiler versions missed:
>
> drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
gcc-9 complains about a blatant uninitialized variable use that
all earlier compiler versions missed:
drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized
in this function [-Wmaybe-uninitialized]
Return -EINVAL instead here.
Cc: sta...@vger.kernel.org
Fixes:
7 matches
Mail list logo