Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

2019-07-14 Thread Jonathan Cameron
On Thu, 4 Jul 2019 21:55:58 +0200 Wolfram Sang wrote: > > >> This is correct but missing that the above 'return ret' is broken, too. > > >> ret is initialized but 0 in that case. > > > > > > Nice catch! Oh well, given enough eyeballs, ... > > > > I don't think ret is initialized, reg is,

Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

2019-07-04 Thread Wolfram Sang
> >> This is correct but missing that the above 'return ret' is broken, too. > >> ret is initialized but 0 in that case. > > > > Nice catch! Oh well, given enough eyeballs, ... > > I don't think ret is initialized, reg is, not ret . It is initialized for the broken 'return ret' *above* the one

Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

2019-07-04 Thread Marek Vasut
On 7/4/19 2:10 PM, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang wrote: >> On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote: >>> gcc-9 complains about a blatant uninitialized variable use that >>> all earlier compiler versions missed: >>>

Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

2019-07-04 Thread Geert Uytterhoeven
Hi Wolfram, On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang wrote: > On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote: > > gcc-9 complains about a blatant uninitialized variable use that > > all earlier compiler versions missed: > > > > drivers/iio/adc/rcar-gyroadc.c:510:5: warning:

Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

2019-07-04 Thread Wolfram Sang
On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote: > gcc-9 complains about a blatant uninitialized variable use that > all earlier compiler versions missed: > > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used > uninitialized in this function [-Wmaybe-uninitialized] >

Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

2019-07-04 Thread Geert Uytterhoeven
Hi Arnd, On Thu, Jul 4, 2019 at 1:38 PM Arnd Bergmann wrote: > gcc-9 complains about a blatant uninitialized variable use that > all earlier compiler versions missed: > > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used > uninitialized in this function [-Wmaybe-uninitialized]

[PATCH] iio: adc: gyroadc: fix uninitialized return code

2019-07-04 Thread Arnd Bergmann
gcc-9 complains about a blatant uninitialized variable use that all earlier compiler versions missed: drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] Return -EINVAL instead here. Cc: sta...@vger.kernel.org Fixes: