Re: [PATCH] iio: adc: replace comma with a semicolon

2017-04-01 Thread Jonathan Cameron
On 30/03/17 14:38, Peter Meerwald-Stadler wrote: > >> On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: >>> Replace a comma between expression statements by a semicolon. This >>> changes the semantics of the code, but given the current indentation >>> appears to be what is intended.

Re: [Outreachy kernel] [PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread Alison Schofield
On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > Replace a comma between expression statements by a semicolon. This > changes the semantics of the code, but given the current indentation > appears to be what is intended. Hi Arushi, Well, you've gotten a lot of comments on this on

Re: [PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread jacopo
Hi Alexandre hope you're doing good! On Thu, Mar 30, 2017 at 07:23:12PM +0200, Alexandre Belloni wrote: > On 30/03/2017 at 15:30:46 +0200, jacopo wrote: > > Hi Arushi, > >thanks for your patch > > > > On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > > > Replace a comma bet

Re: [PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread Alexandre Belloni
On 30/03/2017 at 15:30:46 +0200, jacopo wrote: > Hi Arushi, >thanks for your patch > > On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > > Replace a comma between expression statements by a semicolon. This > > changes the semantics of the code, but given the current indentation

Re: [PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread Peter Meerwald-Stadler
> On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > > Replace a comma between expression statements by a semicolon. This > > changes the semantics of the code, but given the current indentation > > appears to be what is intended. > You can simply say that this fixes what appears t

Re: [PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread jacopo
Hi Arushi, thanks for your patch On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > Replace a comma between expression statements by a semicolon. This > changes the semantics of the code, but given the current indentation > appears to be what is intended. > A simplified version o

[PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread Arushi Singhal
Replace a comma between expression statements by a semicolon. This changes the semantics of the code, but given the current indentation appears to be what is intended. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: // @r@ expression e1,e2; @