Re: [PATCH] iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe

2019-03-03 Thread Jonathan Cameron
On Thu, 21 Feb 2019 09:03:39 +0100 Enric Balletbo i Serra wrote: > On 21/2/19 8:00, Kees Cook wrote: > > On Wed, Feb 20, 2019 at 6:06 PM Gustavo A. R. Silva > > wrote: > >> > >> Refactor some code in order to fix both the technical implementation > >> and the following warnings: > >> > >> driv

Re: [PATCH] iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe

2019-02-21 Thread Enric Balletbo i Serra
On 21/2/19 8:00, Kees Cook wrote: > On Wed, Feb 20, 2019 at 6:06 PM Gustavo A. R. Silva > wrote: >> >> Refactor some code in order to fix both the technical implementation >> and the following warnings: >> >> drivers/iio/accel/cros_ec_accel_legacy.c: In function >> ‘cros_ec_accel_legacy_probe’

Re: [PATCH] iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe

2019-02-20 Thread Kees Cook
On Wed, Feb 20, 2019 at 6:06 PM Gustavo A. R. Silva wrote: > > Refactor some code in order to fix both the technical implementation > and the following warnings: > > drivers/iio/accel/cros_ec_accel_legacy.c: In function > ‘cros_ec_accel_legacy_probe’: > drivers/iio/accel/cros_ec_accel_legacy.c:38

[PATCH] iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe

2019-02-20 Thread Gustavo A. R. Silva
Refactor some code in order to fix both the technical implementation and the following warnings: drivers/iio/accel/cros_ec_accel_legacy.c: In function ‘cros_ec_accel_legacy_probe’: drivers/iio/accel/cros_ec_accel_legacy.c:387:36: warning: this statement may fall through [-Wimplicit-fallthrough=]