Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-11 Thread Jonathan Cameron
On 07/10/15 00:13, Marek Vasut wrote: > On 10/06/2015 16:22, Alexandre Belloni wrote: >> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. >> >> Reported-by: Janusz Użycki >> Signed-off-by: Alexandre Belloni > > Nice find :-) > > Acked-by: Marek Vasut Ah, missed this

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-11 Thread Jonathan Cameron
On 07/10/15 00:13, Marek Vasut wrote: > On 10/06/2015 16:22, Alexandre Belloni wrote: >> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. >> >> Reported-by: Janusz Użycki >> Signed-off-by: Alexandre Belloni

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-08 Thread Marek Vasut
On Wednesday, October 07, 2015 at 09:12:56 AM, Stefan Wahren wrote: > Am 07.10.2015 um 02:44 schrieb Alexandre Belloni: > > Hi, > > > > On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote : > /* The calculated value from the ADC is in Kelvin, we > * want Celsius for hwmon so the offset

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-08 Thread Marek Vasut
On Wednesday, October 07, 2015 at 09:12:56 AM, Stefan Wahren wrote: > Am 07.10.2015 um 02:44 schrieb Alexandre Belloni: > > Hi, > > > > On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote : > /* The calculated value from the ADC is in Kelvin, we > * want Celsius for hwmon so the offset

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-07 Thread Stefan Wahren
Am 07.10.2015 um 02:44 schrieb Alexandre Belloni: > Hi, > > On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote : /* The calculated value from the ADC is in Kelvin, we * want Celsius for hwmon so the offset is - * -272.15 * scale + * -273.15 * scale */ - *val = -1075;

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-07 Thread Stefan Wahren
Am 07.10.2015 um 02:44 schrieb Alexandre Belloni: > Hi, > > On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote : /* The calculated value from the ADC is in Kelvin, we * want Celsius for hwmon so the offset is - * -272.15 * scale + * -273.15 * scale */ - *val = -1075;

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Alexandre Belloni
Hi, On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote : > >>/* The calculated value from the ADC is in Kelvin, we > >>* want Celsius for hwmon so the offset is > >>- * -272.15 * scale > >>+ * -273.15 * scale > >>*/ > >>- *val = -1075; > >>- *val2 = 691699; > >>+ *val = -1079; > >>+ *val2 =

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Marek Vasut
On 10/06/2015 20:43, Stefan Wahren wrote: Hi, Alexandre Belloni hat am 6. Oktober 2015 um 16:22 geschrieben: 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. Reported-by: Janusz Użycki Signed-off-by: Alexandre Belloni --- drivers/staging/iio/adc/mxs-lradc.c | 6

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Marek Vasut
On 10/06/2015 16:22, Alexandre Belloni wrote: 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. Reported-by: Janusz Użycki Signed-off-by: Alexandre Belloni Nice find :-) Acked-by: Marek Vasut (I am using different MUA, please pardon the possible issues) ---

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Stefan Wahren
Hi, > Alexandre Belloni hat am 6. Oktober > 2015 um 16:22 geschrieben: > > > 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. > > Reported-by: Janusz Użycki > Signed-off-by: Alexandre Belloni > --- > drivers/staging/iio/adc/mxs-lradc.c | 6 +++--- > 1 file changed, 3

[PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Alexandre Belloni
0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. Reported-by: Janusz Użycki Signed-off-by: Alexandre Belloni --- drivers/staging/iio/adc/mxs-lradc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/mxs-lradc.c

[PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Alexandre Belloni
0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. Reported-by: Janusz Użycki Signed-off-by: Alexandre Belloni --- drivers/staging/iio/adc/mxs-lradc.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Stefan Wahren
Hi, > Alexandre Belloni hat am 6. Oktober > 2015 um 16:22 geschrieben: > > > 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. > > Reported-by: Janusz Użycki > Signed-off-by: Alexandre Belloni

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Alexandre Belloni
Hi, On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote : > >>/* The calculated value from the ADC is in Kelvin, we > >>* want Celsius for hwmon so the offset is > >>- * -272.15 * scale > >>+ * -273.15 * scale > >>*/ > >>- *val = -1075; > >>- *val2 = 691699; > >>+ *val = -1079; > >>+ *val2 =

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Marek Vasut
On 10/06/2015 16:22, Alexandre Belloni wrote: 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. Reported-by: Janusz Użycki Signed-off-by: Alexandre Belloni Nice find :-) Acked-by: Marek Vasut

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

2015-10-06 Thread Marek Vasut
On 10/06/2015 20:43, Stefan Wahren wrote: Hi, Alexandre Belloni hat am 6. Oktober 2015 um 16:22 geschrieben: 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset. Reported-by: Janusz Użycki