Re: [PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-09-09 Thread Andreas Klinger
Hi Zbyněk, thanks a lot for testing and sharing your results with us. > I do not know how to do this in the development of drivers, whether it makes > sense to put a filter directly into the driver or at least pull the maximum > distance parameter as a variable? In this case one should read

Re: [PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-09-09 Thread Zbyněk Kocur
Hi Andreas, I'm so sorry for the delay. I was working on another project now, and I wasn't entirely devoted to this. I looked at it at the weekend and the modified code is working. I have only tested OpenWRT in build - r10204-38b22b1, kernel 4.14.125. I do not expect complications on other

Re: [PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-09-07 Thread Andreas Klinger
Hi Zbynek, do you have any feedback for us? Thank you, Andreas Zbyněk Kocur schrieb am Mi, 26. Jun 21:50: > Thank you, i will write a feedback after testing. > > > Zbynek > --- > email: zbynek.ko...@fel.cvut.cz > phone: +420 224 354 054 > web: http://www.fel.cvut.cz > Department of

Re: [PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-06-26 Thread Zbyněk Kocur
Thank you, i will write a feedback after testing. Zbynek --- email: zbynek.ko...@fel.cvut.cz phone: +420 224 354 054 web: http://www.fel.cvut.cz Department of Telecommunications Engineering Faculty of Electrical Engineering > On 26 Jun 2019, at 21:49, Jonathan Cameron wrote: > > No rush, it's

Re: [PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-06-26 Thread Jonathan Cameron
On Wed, 26 Jun 2019 20:59:08 +0200 Zbyněk Kocur wrote: > Hello, Andreas, > > Your patch seems to solve my question. I haven't had time to test it because > of holidays. I'll test it as soon as possible. No rush, it's a clear fix anyway so we can queue this up in the rc phase of the next

Re: [PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-06-26 Thread Jonathan Cameron
On Sun, 23 Jun 2019 14:29:10 +0200 Andreas Klinger wrote: > The measured time value in the driver is limited to the maximum distance > which can be read by the sensor. This limitation was wrong and is fixed > by this patch. > > It also takes into account that we are supporting a variety of

[PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-06-23 Thread Andreas Klinger
The measured time value in the driver is limited to the maximum distance which can be read by the sensor. This limitation was wrong and is fixed by this patch. It also takes into account that we are supporting a variety of sensors today and that the recently added sensors have a higher maximum