Re: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet

2019-03-19 Thread 谢欢
It was only called in the tasklet context. root@jeff:~/git/linux-next# git grep -in bnxt_qplib_service_nq drivers/infiniband/hw/bnxt_re/qplib_fp.c:236:static void bnxt_qplib_service_nq(unsigned long data) drivers/infiniband/hw/bnxt_re/qplib_fp.c:390: tasklet_init(&nq->worker, bnxt_qplib_service_n

Re: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet

2019-03-19 Thread Jason Gunthorpe
On Wed, Mar 20, 2019 at 12:36:37AM +0800, Jeff Xie wrote: > It is unnecessary to call spin_lock_bh in a tasklet. > > Signed-off-by: Jeff Xie > --- > drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I'm curious, how did you prove this was alway

[PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet

2019-03-19 Thread Jeff Xie
It is unnecessary to call spin_lock_bh in a tasklet. Signed-off-by: Jeff Xie --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index 71c34d5..e2