Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-05 Thread Andrew Morton
Alexander Viro wrote: > > On Sun, 3 Dec 2000, Linus Torvalds wrote: > > > > > Synching up with Alan and various other stuff. The most important one > > being the fix to the inode dirty block list. > > It doesn't solve the problem. If you unlink a file with dirty metadata > you have a nice

Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-05 Thread Andrew Morton
Alexander Viro wrote: On Sun, 3 Dec 2000, Linus Torvalds wrote: Synching up with Alan and various other stuff. The most important one being the fix to the inode dirty block list. It doesn't solve the problem. If you unlink a file with dirty metadata you have a nice chance to hit

Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-04 Thread Alexander Viro
On Mon, 4 Dec 2000, Stephen C. Tweedie wrote: > Agreed. However, is there any reason to have this as a separate > function? bforget() should _always_ remove the buffer from any inode > queue. You can make that operation conditional on (bh->b_inode != > NULL) if you want to avoid taking the

Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-04 Thread Stephen C. Tweedie
On Mon, Dec 04, 2000 at 01:01:36AM -0500, Alexander Viro wrote: > > It doesn't solve the problem. If you unlink a file with dirty metadata > you have a nice chance to hit the BUG() in inode.c:83. I hope that patch > below closes all remaining holes. See analysis in previous posting > (basically,

Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-04 Thread Andrew Morton
Alexander Viro wrote: > > On Sun, 3 Dec 2000, Linus Torvalds wrote: > > > > > Synching up with Alan and various other stuff. The most important one > > being the fix to the inode dirty block list. > > It doesn't solve the problem. If you unlink a file with dirty metadata > you have a nice

Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-04 Thread Andrew Morton
Alexander Viro wrote: On Sun, 3 Dec 2000, Linus Torvalds wrote: Synching up with Alan and various other stuff. The most important one being the fix to the inode dirty block list. It doesn't solve the problem. If you unlink a file with dirty metadata you have a nice chance to hit

Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-04 Thread Stephen C. Tweedie
On Mon, Dec 04, 2000 at 01:01:36AM -0500, Alexander Viro wrote: It doesn't solve the problem. If you unlink a file with dirty metadata you have a nice chance to hit the BUG() in inode.c:83. I hope that patch below closes all remaining holes. See analysis in previous posting (basically,

Re: [PATCH] inode dirty blocks Re: test12-pre4

2000-12-04 Thread Alexander Viro
On Mon, 4 Dec 2000, Stephen C. Tweedie wrote: Agreed. However, is there any reason to have this as a separate function? bforget() should _always_ remove the buffer from any inode queue. You can make that operation conditional on (bh-b_inode != NULL) if you want to avoid taking the lru

[PATCH] inode dirty blocks Re: test12-pre4

2000-12-03 Thread Alexander Viro
On Sun, 3 Dec 2000, Linus Torvalds wrote: > > Synching up with Alan and various other stuff. The most important one > being the fix to the inode dirty block list. It doesn't solve the problem. If you unlink a file with dirty metadata you have a nice chance to hit the BUG() in inode.c:83. I

[PATCH] inode dirty blocks Re: test12-pre4

2000-12-03 Thread Alexander Viro
On Sun, 3 Dec 2000, Linus Torvalds wrote: Synching up with Alan and various other stuff. The most important one being the fix to the inode dirty block list. It doesn't solve the problem. If you unlink a file with dirty metadata you have a nice chance to hit the BUG() in inode.c:83. I hope