Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Henrique de Moraes Holschuh
On Sun, 18 Feb 2007, Richard Purdie wrote: > I just said that finding a way to do it generically is difficult, not > that we shouldn't do it. Very well, let's do it, then. > Even if half your functionality is exposed through the class, that half > that is standardised rather than adhoc. Having

Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Richard Purdie
On Sun, 2007-02-18 at 08:45 +0100, Németh Márton wrote: > A blinking led is basically a PWM (Pulse Width Modulation) > signal. A PWM signal has three different attribute. The > first one is the amplitude, this attribute is already > provided by the led subsystem as "brightness". There are two >

Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Richard Purdie
On Fri, 2007-02-16 at 01:12 -0200, Henrique de Moraes Holschuh wrote: > On Thu, 15 Feb 2007, Richard Purdie wrote: > > This has been discussed in several places several times. The problem > > with hardware accelerated flashing is that you're are often limited to > > certain constraints (this case

Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Willy Tarreau
On Sun, Feb 18, 2007 at 08:45:00AM +0100, Németh Márton wrote: > > On Fri, 16 Feb 2007, Henrique de Moraes Holschuh wrote: > > On Thu, 15 Feb 2007, Richard Purdie wrote: > > > This has been discussed in several places several times. > The problem > > > with hardware accelerated flashing is that

Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Willy Tarreau
On Sun, Feb 18, 2007 at 08:45:00AM +0100, Németh Márton wrote: On Fri, 16 Feb 2007, Henrique de Moraes Holschuh wrote: On Thu, 15 Feb 2007, Richard Purdie wrote: This has been discussed in several places several times. The problem with hardware accelerated flashing is that you're are

Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Richard Purdie
On Fri, 2007-02-16 at 01:12 -0200, Henrique de Moraes Holschuh wrote: On Thu, 15 Feb 2007, Richard Purdie wrote: This has been discussed in several places several times. The problem with hardware accelerated flashing is that you're are often limited to certain constraints (this case being

Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Richard Purdie
On Sun, 2007-02-18 at 08:45 +0100, Németh Márton wrote: A blinking led is basically a PWM (Pulse Width Modulation) signal. A PWM signal has three different attribute. The first one is the amplitude, this attribute is already provided by the led subsystem as brightness. There are two more

Re: [PATCH] input: extend EV_LED

2007-02-18 Thread Henrique de Moraes Holschuh
On Sun, 18 Feb 2007, Richard Purdie wrote: I just said that finding a way to do it generically is difficult, not that we shouldn't do it. Very well, let's do it, then. Even if half your functionality is exposed through the class, that half that is standardised rather than adhoc. Having said

Re: [PATCH] input: extend EV_LED

2007-02-17 Thread Németh Márton
On Fri, 16 Feb 2007, Henrique de Moraes Holschuh wrote: > On Thu, 15 Feb 2007, Richard Purdie wrote: > > This has been discussed in several places several times. The problem > > with hardware accelerated flashing is that you're are often limited to > > certain constraints (this case being no

Re: [PATCH] input: extend EV_LED

2007-02-17 Thread Németh Márton
On Fri, 16 Feb 2007, Henrique de Moraes Holschuh wrote: On Thu, 15 Feb 2007, Richard Purdie wrote: This has been discussed in several places several times. The problem with hardware accelerated flashing is that you're are often limited to certain constraints (this case being no exception)

Re: [PATCH] input: extend EV_LED

2007-02-16 Thread Pavel Machek
Hi! > >I do not know the LED subsystem in detail, but I do not > >know > >any possibility to access the i8042 from different > >subsystem > >than the input subsystem. > > > >What do you think and recommend? > > I think you need to use leds framework for what you are > trying to do. I'm

Re: [PATCH] input: extend EV_LED

2007-02-16 Thread Pavel Machek
Hi! > > > >I do not know the LED subsystem in detail, but I do not > > > >know > > > >any possibility to access the i8042 from different > > > >subsystem > > > >than the input subsystem. > > > > > > > >What do you think and recommend? > > > > > > I think you need to use leds framework for what

Re: [PATCH] input: extend EV_LED

2007-02-16 Thread Pavel Machek
Hi! I do not know the LED subsystem in detail, but I do not know any possibility to access the i8042 from different subsystem than the input subsystem. What do you think and recommend? I think you need to use leds framework for what you are trying to do.

Re: [PATCH] input: extend EV_LED

2007-02-16 Thread Pavel Machek
Hi! I do not know the LED subsystem in detail, but I do not know any possibility to access the i8042 from different subsystem than the input subsystem. What do you think and recommend? I think you need to use leds framework for what you are trying to do. I'm actually not sure if

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Henrique de Moraes Holschuh
On Thu, 15 Feb 2007, Richard Purdie wrote: > This has been discussed in several places several times. The problem > with hardware accelerated flashing is that you're are often limited to > certain constraints (this case being no exception) and indicating what > these are to userspace in a generic

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Richard Purdie
On Fri, 2007-02-16 at 00:24 +0100, Pavel Machek wrote: > > The led framework is generic. If you can write a function to turn it > > on/off you can drive it with the LED framework. > > Even if that function is slow and sleeps? The LED class itself can call in interrupt context so you'd have to

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Németh Márton
Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > >I do not know the LED subsystem in detail, but I do not > > >know > > >any possibility to access the i8042 from different > > >subsystem > > >than the input subsystem. > > > > > >What do you think and recommend? > > > > I think you need

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Pavel Machek
Hi! > > > > >I do not know the LED subsystem in detail, but I do not > > > > >know any possibility to access the i8042 from different > > > > >subsystem than the input subsystem. > > > > > > > > > >What do you think and recommend? > > > > > > > > I think you need to use leds framework for what

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Richard Purdie
On Thu, 2007-02-15 at 23:47 +0100, Németh Márton wrote: > Pavel Machek <[EMAIL PROTECTED]> wrote: > > > >I do not know the LED subsystem in detail, but I do not > > > >know any possibility to access the i8042 from different > > > >subsystem than the input subsystem. > > > > > > > >What do you

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Henrique de Moraes Holschuh
On Thu, 15 Feb 2007, Richard Purdie wrote: This has been discussed in several places several times. The problem with hardware accelerated flashing is that you're are often limited to certain constraints (this case being no exception) and indicating what these are to userspace in a generic

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Richard Purdie
On Thu, 2007-02-15 at 23:47 +0100, Németh Márton wrote: Pavel Machek [EMAIL PROTECTED] wrote: I do not know the LED subsystem in detail, but I do not know any possibility to access the i8042 from different subsystem than the input subsystem. What do you think and recommend?

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Pavel Machek
Hi! I do not know the LED subsystem in detail, but I do not know any possibility to access the i8042 from different subsystem than the input subsystem. What do you think and recommend? I think you need to use leds framework for what you are trying to do.

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Németh Márton
Pavel Machek [EMAIL PROTECTED] wrote: Hi! I do not know the LED subsystem in detail, but I do not know any possibility to access the i8042 from different subsystem than the input subsystem. What do you think and recommend? I think you need to use leds framework for what

Re: [PATCH] input: extend EV_LED

2007-02-15 Thread Richard Purdie
On Fri, 2007-02-16 at 00:24 +0100, Pavel Machek wrote: The led framework is generic. If you can write a function to turn it on/off you can drive it with the LED framework. Even if that function is slow and sleeps? The LED class itself can call in interrupt context so you'd have to schedule

Re: [PATCH] input: extend EV_LED

2007-02-14 Thread Németh Márton
Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > On 2/14/07, Németh Márton <[EMAIL PROTECTED]> wrote: > > > > > > Dmitry Torokhov <[EMAIL PROTECTED]> írta: > > > > > On 2/11/07, Németh Márton <[EMAIL PROTECTED]> wrote: > > > > > > > > Extend EV_LED handling code so that it can handle not > > > >

Re: [PATCH] input: extend EV_LED

2007-02-14 Thread Dmitry Torokhov
On 2/14/07, Németh Márton <[EMAIL PROTECTED]> wrote: Dmitry Torokhov <[EMAIL PROTECTED]> írta: > On 2/11/07, Németh Márton <[EMAIL PROTECTED]> wrote: > > > > Extend EV_LED handling code so that it can handle not > > only two states (on/off) but also others. For example > > a LED can blink

Re: [PATCH] input: extend EV_LED

2007-02-14 Thread Németh Márton
Dmitry Torokhov <[EMAIL PROTECTED]> írta: > On 2/11/07, Németh Márton <[EMAIL PROTECTED]> wrote: > > > > Extend EV_LED handling code so that it can handle not > > only two states (on/off) but also others. For example > > a LED can blink using hardware acceleration. The code > > changed so that

Re: [PATCH] input: extend EV_LED

2007-02-14 Thread Németh Márton
Dmitry Torokhov [EMAIL PROTECTED] írta: On 2/11/07, Németh Márton [EMAIL PROTECTED] wrote: Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware acceleration. The code changed so that it is similar

Re: [PATCH] input: extend EV_LED

2007-02-14 Thread Dmitry Torokhov
On 2/14/07, Németh Márton [EMAIL PROTECTED] wrote: Dmitry Torokhov [EMAIL PROTECTED] írta: On 2/11/07, Németh Márton [EMAIL PROTECTED] wrote: Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware

Re: [PATCH] input: extend EV_LED

2007-02-14 Thread Németh Márton
Dmitry Torokhov [EMAIL PROTECTED] wrote: On 2/14/07, Németh Márton [EMAIL PROTECTED] wrote: Dmitry Torokhov [EMAIL PROTECTED] írta: On 2/11/07, Németh Márton [EMAIL PROTECTED] wrote: Extend EV_LED handling code so that it can handle not only two states (on/off) but also

Re: [PATCH] input: extend EV_LED

2007-02-12 Thread Dmitry Torokhov
On 2/11/07, Németh Márton <[EMAIL PROTECTED]> wrote: Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware acceleration. The code changed so that it is similar to the code at EV_SND. Hi, I am not sure we

Re: [PATCH] input: extend EV_LED

2007-02-12 Thread Dmitry Torokhov
On 2/11/07, Németh Márton [EMAIL PROTECTED] wrote: Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware acceleration. The code changed so that it is similar to the code at EV_SND. Hi, I am not sure we

[PATCH] input: extend EV_LED

2007-02-11 Thread Németh Márton
Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware acceleration. The code changed so that it is similar to the code at EV_SND. Signed-off-by: Márton Németh <[EMAIL PROTECTED]> --- diff -uprN

[PATCH] input: extend EV_LED

2007-02-11 Thread Németh Márton
Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware acceleration. The code changed so that it is similar to the code at EV_SND. Signed-off-by: Márton Németh [EMAIL PROTECTED] --- diff -uprN