Re: [PATCH] input: gpio_keys: Fix check for disabling unsupported key

2016-01-06 Thread Dmitry Torokhov
On Tue, Jan 05, 2016 at 09:24:40AM +0200, Ivaylo Dimitrov wrote: > Hi, > > On 5.01.2016 03:19, Dmitry Torokhov wrote: > >>/* First validate */ > >>- for (i = 0; i < ddata->pdata->nbuttons; i++) { > >>- struct gpio_button_data *bdata = &ddata->data[i]; > >>+ for (i = 0; i < n_eve

Re: [PATCH] input: gpio_keys: Fix check for disabling unsupported key

2016-01-04 Thread Ivaylo Dimitrov
Hi, On 5.01.2016 03:19, Dmitry Torokhov wrote: /* First validate */ - for (i = 0; i < ddata->pdata->nbuttons; i++) { - struct gpio_button_data *bdata = &ddata->data[i]; + for (i = 0; i < n_events; i++) { for_each_set_bit()? Yeah, seems I must have overslept

Re: [PATCH] input: gpio_keys: Fix check for disabling unsupported key

2016-01-04 Thread Dmitry Torokhov
On Sun, Jan 03, 2016 at 11:21:16PM +0200, Ivaylo Dimitrov wrote: > Commit 4ea14a53d8f881034fa9e186653821c4e3d9a8fb ("Input: gpio-keys - > report error when disabling unsupported key") tried to prevent an > unsupported key to disabled. Unfortunately it effectively broke the driver > in a way so no k

[PATCH] input: gpio_keys: Fix check for disabling unsupported key

2016-01-03 Thread Ivaylo Dimitrov
Commit 4ea14a53d8f881034fa9e186653821c4e3d9a8fb ("Input: gpio-keys - report error when disabling unsupported key") tried to prevent an unsupported key to disabled. Unfortunately it effectively broke the driver in a way so no key is possible to be disabled. Fix that by providing the correct verify l