Re: [PATCH] input: move gpio mouse to managed api

2017-05-21 Thread Bram Vlerick
Hi Dmitry, I've updated the patch with your comments, unregistering first before freeing the gpios. In regards of your comment for the gpio-keys-polled update, I've just started with kernel dev and thought moving old drivers to the new managed api was a good start. So I don't really know how to

Re: [PATCH] input: move gpio mouse to managed api

2017-05-21 Thread Bram Vlerick
Hi Dmitry, I've updated the patch with your comments, unregistering first before freeing the gpios. In regards of your comment for the gpio-keys-polled update, I've just started with kernel dev and thought moving old drivers to the new managed api was a good start. So I don't really know how to

[PATCH] input: move gpio mouse to managed api

2017-05-20 Thread Bram Vlerick
Signed-off-by: Bram Vlerick --- drivers/input/mouse/gpio_mouse.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c index ced07391304b..2fc8ddaf0175 100644 ---

[PATCH] input: move gpio mouse to managed api

2017-05-20 Thread Bram Vlerick
Signed-off-by: Bram Vlerick --- drivers/input/mouse/gpio_mouse.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c index ced07391304b..2fc8ddaf0175 100644 --- a/drivers/input/mouse/gpio_mouse.c +++

Re: [PATCH] input: move gpio mouse to managed api

2017-05-19 Thread Dmitry Torokhov
Hi Bram, On Fri, May 19, 2017 at 05:35:02PM +0200, Bram Vlerick wrote: > Signed-off-by: Bram Vlerick > --- > drivers/input/mouse/gpio_mouse.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/mouse/gpio_mouse.c >

Re: [PATCH] input: move gpio mouse to managed api

2017-05-19 Thread Dmitry Torokhov
Hi Bram, On Fri, May 19, 2017 at 05:35:02PM +0200, Bram Vlerick wrote: > Signed-off-by: Bram Vlerick > --- > drivers/input/mouse/gpio_mouse.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/mouse/gpio_mouse.c >

Re: [PATCH] input: move gpio mouse to managed api

2017-05-19 Thread Michael Opdenacker
On 19/05/2017 17:35, Bram Vlerick wrote: > Signed-off-by: Bram Vlerick > --- > drivers/input/mouse/gpio_mouse.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/mouse/gpio_mouse.c > b/drivers/input/mouse/gpio_mouse.c > index

Re: [PATCH] input: move gpio mouse to managed api

2017-05-19 Thread Michael Opdenacker
On 19/05/2017 17:35, Bram Vlerick wrote: > Signed-off-by: Bram Vlerick > --- > drivers/input/mouse/gpio_mouse.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/mouse/gpio_mouse.c > b/drivers/input/mouse/gpio_mouse.c > index

[PATCH] input: move gpio mouse to managed api

2017-05-19 Thread Bram Vlerick
Signed-off-by: Bram Vlerick --- drivers/input/mouse/gpio_mouse.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c index ced07391304b..7d56fd5173bc 100644 ---

[PATCH] input: move gpio mouse to managed api

2017-05-19 Thread Bram Vlerick
Signed-off-by: Bram Vlerick --- drivers/input/mouse/gpio_mouse.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c index ced07391304b..7d56fd5173bc 100644 --- a/drivers/input/mouse/gpio_mouse.c +++