Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Zhang Rui
On Wed, 2020-08-26 at 19:00 +0200, Rafael J. Wysocki wrote: > On Wed, Aug 26, 2020 at 6:46 PM Guilhem Lettron > wrote: > > > > I've done more tests, maybe it can give you more hints. > > I don't see that much differences between both (with and without > > patches) in this cases. > > OK, thanks!

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:46 PM Guilhem Lettron wrote: > > I've done more tests, maybe it can give you more hints. > I don't see that much differences between both (with and without > patches) in this cases. OK, thanks! I'm assuming that the topmost two sets of data are for the "without the

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
On Wed, 2020-08-26 at 18:43 +0200, Rafael J. Wysocki wrote: > > I am curious, somehow that patch makes a difference. > > It does make a difference, because it makes the processor spend more > time in PC2. Which very well may be because the processor cannot > enter deeper C-states. OK, you are

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
I've done more tests, maybe it can give you more hints. I don't see that much differences between both (with and without patches) in this cases. -- Guilhem Lettron CoreCPU Avg_MHz Busy% Bzy_MHz TSC_MHz IRQ SMI POLLC1_ACPI C2_ACPI C3_ACPI POLL% C1_ACPI%C2_ACPI%

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:39 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 18:02 +0200, Rafael J. Wysocki wrote: > > To that end, I would try to upgrade the graphics firmware and see if > > you can get some nonzero PC8 residency then. > > I am curious, somehow that patch makes a

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:19 PM Artem Bityutskiy wrote: > > Indeed, when I compare them: > > acpi_idle (without the patch): Does this come from the Guilhem's data? It's intel_idle in both cases, but in the "without the patch" case it uses ACPI. > CPU%c1 CPU%c6 CPU%c7 CoreTmp PkgTmp GFX%rc6

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
On Wed, 2020-08-26 at 18:02 +0200, Rafael J. Wysocki wrote: > To that end, I would try to upgrade the graphics firmware and see if > you can get some nonzero PC8 residency then. I am curious, somehow that patch makes a difference. Guilhem, what do we actually compare: same kernel, just patched

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
On Wed, 2020-08-26 at 19:25 +0300, Artem Bityutskiy wrote: > C6 Ok, too long day, I meant C10 here...

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
On Wed, 2020-08-26 at 19:19 +0300, Artem Bityutskiy wrote: > May be there is a BIOS update that fixes this problem? May be Windows > user get it quickly because stuff like this is often well-integrated in > Windows? Would you please check if there is newer BIOS? Oh, wait a second. So ACPI_C3 is

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:02 PM Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 4:04 PM Guilhem Lettron wrote: > > > > On Wed, 26 Aug 2020 at 15:41, Zhang Rui wrote: > > > > > > > > > This is really hard to read. > > > can you please attach the two turbostat output as attachments? > > > >

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
Indeed, when I compare them: acpi_idle (without the patch): CPU%c1 CPU%c6 CPU%c7 CoreTmp PkgTmp GFX%rc6 Pkg%pc2 Pkg%pc3 Pkg%pc6 Pkg%pc7 Pkg%pc8 Pkg%pc9 Pk%pc10 PkgWatt 29.48 0.0060.71 58 58 97.96 16.96 0.000.000.00 0.000.000.006.08 intel_idle

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 4:04 PM Guilhem Lettron wrote: > > On Wed, 26 Aug 2020 at 15:41, Zhang Rui wrote: > > > > > > This is really hard to read. > > can you please attach the two turbostat output as attachments? > > of course :) Thanks! A couple of things happen here AFAICS. First, your

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 15:41, Zhang Rui wrote: > > > This is really hard to read. > can you please attach the two turbostat output as attachments? of course :) Guilhem Lettron turbostat version 20.03.20 - Len Brown CPUID(0): GenuineIntel 0x1b CPUID levels; 0x8008 xlevels;

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Zhang Rui
On Wed, 2020-08-26 at 15:32 +0200, Guilhem Lettron wrote: > On Wed, 26 Aug 2020 at 15:18, Artem Bityutskiy > wrote: > > > > On Wed, 2020-08-26 at 16:16 +0300, Artem Bityutskiy wrote: > > > Just get a reasonably new turbostat (it is part of the kernel > > > tree, you > > > can compile it

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 15:17, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:59 PM Guilhem Lettron wrote: > > > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only report > > "C1_ACPI", "C2_ACPI" and "C3_ACPI". > > Can you list the properties of the idle states in this

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 15:18, Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 16:16 +0300, Artem Bityutskiy wrote: > > Just get a reasonably new turbostat (it is part of the kernel tree, you > > can compile it yourself) and run it for few seconds (like 'turbostat > > sleep 10'), get the output

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 3:18 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 16:16 +0300, Artem Bityutskiy wrote: > > Just get a reasonably new turbostat (it is part of the kernel tree, you > > can compile it yourself) and run it for few seconds (like 'turbostat > > sleep 10'), get the

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 3:09 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > > On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron > > > wrote: > > > > Use the same C-states as SKL > > > > > >

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 15:09, Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only > > report "C1_ACPI", "C2_ACPI" and "C3_ACPI". > > Did you try to dig into the BIOS menus and check if you can

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
On Wed, 2020-08-26 at 16:16 +0300, Artem Bityutskiy wrote: > Just get a reasonably new turbostat (it is part of the kernel tree, you > can compile it yourself) and run it for few seconds (like 'turbostat > sleep 10'), get the output (will be a lot of it), and we can check what > is actually going

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 2:59 PM Guilhem Lettron wrote: > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only report > "C1_ACPI", "C2_ACPI" and "C3_ACPI". Can you list the properties of the idle states in this configuration, that is: $ grep -r '.*'

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > > Use the same C-states as SKL > > > > Why is this change needed? > > On my laptop, a Dell XPS 13 7390 2-in-1 with

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Artem Bityutskiy
On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > > Use the same C-states as SKL > > > > Why is this change needed? > > On my laptop, a Dell XPS 13 7390 2-in-1 with

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > > > Use the same C-states as SKL > > Why is this change needed? On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only report "C1_ACPI", "C2_ACPI" and "C3_ACPI".

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > Use the same C-states as SKL Why is this change needed? > Signed-off-by: Guilhem Lettron > --- > drivers/idle/intel_idle.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/idle/intel_idle.c

[PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
Use the same C-states as SKL Signed-off-by: Guilhem Lettron --- drivers/idle/intel_idle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index 8e0fb1a5bdbd..1bb539f09a4f 100644 --- a/drivers/idle/intel_idle.c +++