Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-05 Thread Matthew Wilcox
On Sat, Jun 06, 2020 at 07:48:41AM +1000, Dave Chinner wrote: > On Fri, Jun 05, 2020 at 05:48:26AM -0700, Matthew Wilcox wrote: > > ... I don't think that's the interesting path. I mean, that's > > the submission path, and usually we discover errors in the completion > > path, not the submission

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-05 Thread Dave Chinner
On Fri, Jun 05, 2020 at 05:48:26AM -0700, Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 01:07:58PM +1000, Dave Chinner wrote: > > On Thu, Jun 04, 2020 at 07:24:51PM -0700, Matthew Wilcox wrote: > > > On Fri, Jun 05, 2020 at 10:31:59AM +1000, Dave Chinner wrote: > > > > On Thu, Jun 04, 2020 at

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-05 Thread Darrick J. Wong
On Fri, Jun 05, 2020 at 05:48:26AM -0700, Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 01:07:58PM +1000, Dave Chinner wrote: > > On Thu, Jun 04, 2020 at 07:24:51PM -0700, Matthew Wilcox wrote: > > > On Fri, Jun 05, 2020 at 10:31:59AM +1000, Dave Chinner wrote: > > > > On Thu, Jun 04, 2020 at

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-05 Thread Matthew Wilcox
On Fri, Jun 05, 2020 at 01:07:58PM +1000, Dave Chinner wrote: > On Thu, Jun 04, 2020 at 07:24:51PM -0700, Matthew Wilcox wrote: > > On Fri, Jun 05, 2020 at 10:31:59AM +1000, Dave Chinner wrote: > > > On Thu, Jun 04, 2020 at 04:50:50PM -0700, Matthew Wilcox wrote: > > > > > Sure, but that's not

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Dave Chinner
On Thu, Jun 04, 2020 at 07:24:51PM -0700, Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 10:31:59AM +1000, Dave Chinner wrote: > > On Thu, Jun 04, 2020 at 04:50:50PM -0700, Matthew Wilcox wrote: > > > > Sure, but that's not really what I was asking: why isn't this > > > > !uptodate state caught

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Matthew Wilcox
On Fri, Jun 05, 2020 at 10:31:59AM +1000, Dave Chinner wrote: > On Thu, Jun 04, 2020 at 04:50:50PM -0700, Matthew Wilcox wrote: > > > Sure, but that's not really what I was asking: why isn't this > > > !uptodate state caught before the page fault code calls > > > ->page_mkwrite? The page fault

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Dave Chinner
On Thu, Jun 04, 2020 at 04:50:50PM -0700, Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 09:30:53AM +1000, Dave Chinner wrote: > > On Thu, Jun 04, 2020 at 04:05:19PM -0700, Matthew Wilcox wrote: > > > On Fri, Jun 05, 2020 at 08:57:26AM +1000, Dave Chinner wrote: > > > > On Thu, Jun 04, 2020 at

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Matthew Wilcox
On Fri, Jun 05, 2020 at 09:30:53AM +1000, Dave Chinner wrote: > On Thu, Jun 04, 2020 at 04:05:19PM -0700, Matthew Wilcox wrote: > > On Fri, Jun 05, 2020 at 08:57:26AM +1000, Dave Chinner wrote: > > > On Thu, Jun 04, 2020 at 01:23:40PM -0700, Matthew Wilcox wrote: > > > > From: "Matthew Wilcox

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Dave Chinner
On Thu, Jun 04, 2020 at 04:05:19PM -0700, Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 08:57:26AM +1000, Dave Chinner wrote: > > On Thu, Jun 04, 2020 at 01:23:40PM -0700, Matthew Wilcox wrote: > > > From: "Matthew Wilcox (Oracle)" > > > > > > Test generic/019 often results in: > > > > > >

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Matthew Wilcox
On Fri, Jun 05, 2020 at 08:57:26AM +1000, Dave Chinner wrote: > On Thu, Jun 04, 2020 at 01:23:40PM -0700, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Test generic/019 often results in: > > > > WARNING: at fs/iomap/buffered-io.c:1069 iomap_page_mkwrite_actor+0x57/0x70 > >

Re: [PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Dave Chinner
On Thu, Jun 04, 2020 at 01:23:40PM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Test generic/019 often results in: > > WARNING: at fs/iomap/buffered-io.c:1069 iomap_page_mkwrite_actor+0x57/0x70 > > Since this can happen due to a storage error, we should not WARN for it. >

[PATCH] iomap: Handle I/O errors gracefully in page_mkwrite

2020-06-04 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" Test generic/019 often results in: WARNING: at fs/iomap/buffered-io.c:1069 iomap_page_mkwrite_actor+0x57/0x70 Since this can happen due to a storage error, we should not WARN for it. Just return -EIO, which will be converted to a SIGBUS for the hapless task