Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-18 Thread JeffyChen
Hi Will, Thanks for your reply. On 01/18/2018 10:41 PM, Will Deacon wrote: > >Makes sense to me, but I'd like to have an OK from Robin or Will (added >to Cc) before applying this. I don't think this patch makes a lot of sense in isolation: the SMMU drivers themselves will likely still probe,

Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-18 Thread JeffyChen
Hi Will, Thanks for your reply. On 01/18/2018 10:41 PM, Will Deacon wrote: > >Makes sense to me, but I'd like to have an OK from Robin or Will (added >to Cc) before applying this. I don't think this patch makes a lot of sense in isolation: the SMMU drivers themselves will likely still probe,

Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-18 Thread Will Deacon
On Wed, Jan 17, 2018 at 02:28:08PM +0100, Joerg Roedel wrote: > On Wed, Jan 03, 2018 at 02:09:20PM +0800, Jeffy Chen wrote: > > The for_each_matching_node_and_match() would return every matching > > nodes including unavailable ones. > > > > It's pointless to init unavailable IOMMUs, so add a

Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-18 Thread Will Deacon
On Wed, Jan 17, 2018 at 02:28:08PM +0100, Joerg Roedel wrote: > On Wed, Jan 03, 2018 at 02:09:20PM +0800, Jeffy Chen wrote: > > The for_each_matching_node_and_match() would return every matching > > nodes including unavailable ones. > > > > It's pointless to init unavailable IOMMUs, so add a

Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-17 Thread Joerg Roedel
On Wed, Jan 03, 2018 at 02:09:20PM +0800, Jeffy Chen wrote: > The for_each_matching_node_and_match() would return every matching > nodes including unavailable ones. > > It's pointless to init unavailable IOMMUs, so add a sanity check to > avoid that. > > Signed-off-by: Jeffy Chen

Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-17 Thread Joerg Roedel
On Wed, Jan 03, 2018 at 02:09:20PM +0800, Jeffy Chen wrote: > The for_each_matching_node_and_match() would return every matching > nodes including unavailable ones. > > It's pointless to init unavailable IOMMUs, so add a sanity check to > avoid that. > > Signed-off-by: Jeffy Chen > --- > >

Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-08 Thread Robin Murphy
Hi Jeffy, On 03/01/18 06:09, Jeffy Chen wrote: The for_each_matching_node_and_match() would return every matching nodes including unavailable ones. It's pointless to init unavailable IOMMUs, so add a sanity check to avoid that. Even better would be to clean up the last remaining init_fn user

Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-08 Thread Robin Murphy
Hi Jeffy, On 03/01/18 06:09, Jeffy Chen wrote: The for_each_matching_node_and_match() would return every matching nodes including unavailable ones. It's pointless to init unavailable IOMMUs, so add a sanity check to avoid that. Even better would be to clean up the last remaining init_fn user

[PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-02 Thread Jeffy Chen
The for_each_matching_node_and_match() would return every matching nodes including unavailable ones. It's pointless to init unavailable IOMMUs, so add a sanity check to avoid that. Signed-off-by: Jeffy Chen --- drivers/iommu/of_iommu.c | 3 +++ 1 file changed, 3

[PATCH] iommu/of: Only do IOMMU lookup for available ones

2018-01-02 Thread Jeffy Chen
The for_each_matching_node_and_match() would return every matching nodes including unavailable ones. It's pointless to init unavailable IOMMUs, so add a sanity check to avoid that. Signed-off-by: Jeffy Chen --- drivers/iommu/of_iommu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git