Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-18 Thread Christoph Hellwig
On Fri, Oct 18, 2019 at 05:21:49PM +0200, Joerg Roedel wrote: > > > Fine with me. > > > > > > Acked-by: Joerg Roedel > > > > That means you want me to queue it up? > > Yes, feel free to take it into your tree. Done.

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-18 Thread Joerg Roedel
On Fri, Oct 18, 2019 at 05:14:53PM +0200, Christoph Hellwig wrote: > On Fri, Oct 18, 2019 at 11:50:37AM +0200, Joerg Roedel wrote: > > On Thu, Oct 17, 2019 at 09:08:47AM +0200, Christoph Hellwig wrote: > > > On Wed, Oct 16, 2019 at 03:15:52PM -0400, Arvind Sankar wrote: > > > > > > Reported-by: Arv

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-18 Thread Christoph Hellwig
On Fri, Oct 18, 2019 at 11:50:37AM +0200, Joerg Roedel wrote: > On Thu, Oct 17, 2019 at 09:08:47AM +0200, Christoph Hellwig wrote: > > On Wed, Oct 16, 2019 at 03:15:52PM -0400, Arvind Sankar wrote: > > > > > Reported-by: Arvind Sankar > > > > > Tested-by: Arvind Sankar > > > > > Originally-by: Ch

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-18 Thread Joerg Roedel
On Thu, Oct 17, 2019 at 09:08:47AM +0200, Christoph Hellwig wrote: > On Wed, Oct 16, 2019 at 03:15:52PM -0400, Arvind Sankar wrote: > > > > Reported-by: Arvind Sankar > > > > Tested-by: Arvind Sankar > > > > Originally-by: Christoph Hellwig > > > > Signed-off-by: Christoph Hellwig > > > > Fixed

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-17 Thread Christoph Hellwig
On Wed, Oct 16, 2019 at 03:15:52PM -0400, Arvind Sankar wrote: > > > Reported-by: Arvind Sankar > > > Tested-by: Arvind Sankar > > > Originally-by: Christoph Hellwig > > > Signed-off-by: Christoph Hellwig > > > Fixed-by: Arvind Sankar > > > Signed-off-by: Arvind Sankar > > > > This patch loo

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-16 Thread Arvind Sankar
On Thu, Oct 10, 2019 at 09:26:37AM +0800, Lu Baolu wrote: > Hi, > > On 10/8/19 10:33 PM, Arvind Sankar wrote: > > We must return a mask covering the full physical RAM when bypassing the > > IOMMU mapping. Also, in iommu_need_mapping, we need to check using > > dma_direct_get_required_mask to ensur

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-09 Thread Lu Baolu
Hi, On 10/8/19 10:33 PM, Arvind Sankar wrote: We must return a mask covering the full physical RAM when bypassing the IOMMU mapping. Also, in iommu_need_mapping, we need to check using dma_direct_get_required_mask to ensure that the device's dma_mask can cover physical RAM before deciding to byp

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-09 Thread Lu Baolu
Hi Christoph, On 10/9/19 2:51 PM, Christoph Hellwig wrote: On Wed, Oct 09, 2019 at 10:45:15AM +0800, Lu Baolu wrote: Do you mind explaining why we always return 32 bit here? See the comment in dma_get_required_mask(). Got it. Thank you. Best regards, Baolu

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-08 Thread Christoph Hellwig
On Wed, Oct 09, 2019 at 10:45:15AM +0800, Lu Baolu wrote: > Do you mind explaining why we always return 32 bit here? See the comment in dma_get_required_mask().

Re: [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-08 Thread Lu Baolu
Hi, On 10/8/19 10:33 PM, Arvind Sankar wrote: We must return a mask covering the full physical RAM when bypassing the IOMMU mapping. Also, in iommu_need_mapping, we need to check using dma_direct_get_required_mask to ensure that the device's dma_mask can cover physical RAM before deciding to byp

[PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU

2019-10-08 Thread Arvind Sankar
We must return a mask covering the full physical RAM when bypassing the IOMMU mapping. Also, in iommu_need_mapping, we need to check using dma_direct_get_required_mask to ensure that the device's dma_mask can cover physical RAM before deciding to bypass IOMMU mapping. Fixes: 249baa547901 ("dma-map