Hi!
> > > +static irqreturn_t ipwireless_handle_v1_interrupt(int irq,
> > > + struct ipw_hardware *hw)
> > > +{
> > > + unsigned short irqn;
> > > + unsigned short ack;
> > > +
> > > + irqn = inw(hw->base_port + IOIR);
> > > +
> > > + /* Check if card is
Hi,
> > +/* DCR bits */
> > +#define DCR_RXDONE ((unsigned short) 0x1)
> > +#define DCR_TXDONE ((unsigned short) 0x2)
> > +#define DCR_RXRESET ((unsigned short) 0x4)
> > +#define DCR_TXRESET ((unsigned short) 0x8)
>
> Are those casts neccessary?
No, removed.
> > +/* I/O ports
Hi,
+/* DCR bits */
+#define DCR_RXDONE ((unsigned short) 0x1)
+#define DCR_TXDONE ((unsigned short) 0x2)
+#define DCR_RXRESET ((unsigned short) 0x4)
+#define DCR_TXRESET ((unsigned short) 0x8)
Are those casts neccessary?
No, removed.
+/* I/O ports and bit
Hi!
+static irqreturn_t ipwireless_handle_v1_interrupt(int irq,
+ struct ipw_hardware *hw)
+{
+ unsigned short irqn;
+ unsigned short ack;
+
+ irqn = inw(hw-base_port + IOIR);
+
+ /* Check if card is present */
+ if (irqn ==
On Thu 2008-01-31 10:29:30, Stephen Blackheath [to Foxconn] wrote:
> Pavel & all,
>
>
> Pavel Machek wrote:
>
> >> +/* I/O ports and bit definitions for version 2 of the hardware */
> >> +
> >> +struct MEMCCR {
> >> + unsigned short PCCOR; /* Configuration Option Register */
> >> +
Pavel & all,
Pavel Machek wrote:
>> +/* I/O ports and bit definitions for version 2 of the hardware */
>> +
>> +struct MEMCCR {
>> +unsigned short PCCOR; /* Configuration Option Register */
>> +unsigned short PCCSR; /* Configuration and Status Register */
>> +
Hi!
> +/* I/O ports and bit definitions for version 1 of the hardware */
> +
> +/* IER bits*/
> +#define IER_RXENABLED ((unsigned short) 0x1)
> +#define IER_TXENABLED ((unsigned short) 0x2)
> +
> +/* ISR bits */
> +#define IR_RXINTR ((unsigned short) 0x1)
> +#define IR_TXINTR
On Mon 2008-01-28 20:53:57, Alexey Dobriyan wrote:
> On Mon, Jan 28, 2008 at 06:19:29PM +0100, David Sterba wrote:
> > ipwireless: driver for PC Card, 3G internet connection
>
> > +struct nl_first_paket_header {
> > +#if defined(__BIG_ENDIAN)
> > + unsigned char packet_rank:2;
> > + unsigned
On Mon 2008-01-28 20:53:57, Alexey Dobriyan wrote:
On Mon, Jan 28, 2008 at 06:19:29PM +0100, David Sterba wrote:
ipwireless: driver for PC Card, 3G internet connection
+struct nl_first_paket_header {
+#if defined(__BIG_ENDIAN)
+ unsigned char packet_rank:2;
+ unsigned char
Hi!
+/* I/O ports and bit definitions for version 1 of the hardware */
+
+/* IER bits*/
+#define IER_RXENABLED ((unsigned short) 0x1)
+#define IER_TXENABLED ((unsigned short) 0x2)
+
+/* ISR bits */
+#define IR_RXINTR ((unsigned short) 0x1)
+#define IR_TXINTR ((unsigned
Pavel all,
Pavel Machek wrote:
+/* I/O ports and bit definitions for version 2 of the hardware */
+
+struct MEMCCR {
+unsigned short PCCOR; /* Configuration Option Register */
+unsigned short PCCSR; /* Configuration and Status Register */
+unsigned short
On Thu 2008-01-31 10:29:30, Stephen Blackheath [to Foxconn] wrote:
Pavel all,
Pavel Machek wrote:
+/* I/O ports and bit definitions for version 2 of the hardware */
+
+struct MEMCCR {
+ unsigned short PCCOR; /* Configuration Option Register */
+ unsigned short PCCSR;
On Tuesday 29 of January 2008 00:18:03 Jiri Slaby wrote:
> On 01/28/2008 07:08 PM, Randy Dunlap wrote:
> >> +/*
> >> + * @return 1 if something has been received from hw
> >
> > What's with the '@'?
>
> ...
>
> >> +
> >> +/*!
> >
> > and the '!' ?
> >
> >> + * @return true if the card is
On Monday 28 of January 2008 19:08:54 Randy Dunlap wrote:
> > +/* Number of bytes in NL packet header (can not do
>
> cannot
Fixed.
>
> > + * sizeof(nl_packet_header) since it's a bitfield) */
> > +#define NL_FOLLOWING_PACKET_HEADER_SIZE1
> > +
> > +struct nl_first_paket_header {
>
>
On Tuesday 29 of January 2008 00:18:03 Jiri Slaby wrote:
On 01/28/2008 07:08 PM, Randy Dunlap wrote:
+/*
+ * @return 1 if something has been received from hw
What's with the '@'?
...
+
+/*!
and the '!' ?
+ * @return true if the card is physically present.
+ */
What
On Monday 28 of January 2008 19:08:54 Randy Dunlap wrote:
+/* Number of bytes in NL packet header (can not do
cannot
Fixed.
+ * sizeof(nl_packet_header) since it's a bitfield) */
+#define NL_FOLLOWING_PACKET_HEADER_SIZE1
+
+struct nl_first_paket_header {
Hi,
On Jan 29, 2008 1:33 AM, Randy Dunlap <[EMAIL PROTECTED]> wrote:
> > > What part of kernel documentation uses doxygen?
> >
> > So then, what's the problem?
>
> Why is it there? We have a kernel documentation language.
> Please use it or plain text.
Yes please.
Pekka
On Tue, 29 Jan 2008 00:29:19 +0100 Jiri Slaby wrote:
> On 01/29/2008 12:28 AM, Randy Dunlap wrote:
> > On Tue, 29 Jan 2008 00:18:03 +0100 Jiri Slaby wrote:
> >
> >> On 01/28/2008 07:08 PM, Randy Dunlap wrote:
> +/*
> + * @return 1 if something has been received from hw
> >>> What's
On 01/29/2008 12:28 AM, Randy Dunlap wrote:
On Tue, 29 Jan 2008 00:18:03 +0100 Jiri Slaby wrote:
On 01/28/2008 07:08 PM, Randy Dunlap wrote:
+/*
+ * @return 1 if something has been received from hw
What's with the '@'?
...
+
+/*!
and the '!' ?
+ * @return true if the card is physically
On Tue, 29 Jan 2008 00:18:03 +0100 Jiri Slaby wrote:
> On 01/28/2008 07:08 PM, Randy Dunlap wrote:
> >> +/*
> >> + * @return 1 if something has been received from hw
> >
> > What's with the '@'?
> ...
> >> +
> >> +/*!
> >
> > and the '!' ?
> >
> >> + * @return true if the card is physically
On 01/28/2008 07:08 PM, Randy Dunlap wrote:
+/*
+ * @return 1 if something has been received from hw
What's with the '@'?
...
+
+/*!
and the '!' ?
+ * @return true if the card is physically present.
+ */
What exactly is wrong with @ and !? It's perfectly doxygen-styled.
diff --git
On Mon, 28 Jan 2008 18:19:29 +0100 David Sterba wrote:
[resending due to send problems, sorry about any dups]
> Hi Linus,
>
> I'm submitting driver for IPWireless PC Card modem for inclusion to 2.6.25.
>
> The driver has been in -mm series as ipwireless_cs.git tree for
> some time and has
On Mon, Jan 28, 2008 at 06:19:29PM +0100, David Sterba wrote:
> ipwireless: driver for PC Card, 3G internet connection
> +struct nl_first_paket_header {
> +#if defined(__BIG_ENDIAN)
> + unsigned char packet_rank:2;
> + unsigned char address:3;
> + unsigned char protocol:3;
> +#else
>
On Mon, Jan 28, 2008 at 06:19:29PM +0100, David Sterba wrote:
ipwireless: driver for PC Card, 3G internet connection
+struct nl_first_paket_header {
+#if defined(__BIG_ENDIAN)
+ unsigned char packet_rank:2;
+ unsigned char address:3;
+ unsigned char protocol:3;
+#else
+
On 01/28/2008 07:08 PM, Randy Dunlap wrote:
+/*
+ * @return 1 if something has been received from hw
What's with the '@'?
...
+
+/*!
and the '!' ?
+ * @return true if the card is physically present.
+ */
What exactly is wrong with @ and !? It's perfectly doxygen-styled.
diff --git
On Tue, 29 Jan 2008 00:18:03 +0100 Jiri Slaby wrote:
On 01/28/2008 07:08 PM, Randy Dunlap wrote:
+/*
+ * @return 1 if something has been received from hw
What's with the '@'?
...
+
+/*!
and the '!' ?
+ * @return true if the card is physically present.
+ */
What
On 01/29/2008 12:28 AM, Randy Dunlap wrote:
On Tue, 29 Jan 2008 00:18:03 +0100 Jiri Slaby wrote:
On 01/28/2008 07:08 PM, Randy Dunlap wrote:
+/*
+ * @return 1 if something has been received from hw
What's with the '@'?
...
+
+/*!
and the '!' ?
+ * @return true if the card is physically
On Tue, 29 Jan 2008 00:29:19 +0100 Jiri Slaby wrote:
On 01/29/2008 12:28 AM, Randy Dunlap wrote:
On Tue, 29 Jan 2008 00:18:03 +0100 Jiri Slaby wrote:
On 01/28/2008 07:08 PM, Randy Dunlap wrote:
+/*
+ * @return 1 if something has been received from hw
What's with the '@'?
...
+
Hi,
On Jan 29, 2008 1:33 AM, Randy Dunlap [EMAIL PROTECTED] wrote:
What part of kernel documentation uses doxygen?
So then, what's the problem?
Why is it there? We have a kernel documentation language.
Please use it or plain text.
Yes please.
Pekka
--
To
On Mon, 28 Jan 2008 18:19:29 +0100 David Sterba wrote:
[resending due to send problems, sorry about any dups]
Hi Linus,
I'm submitting driver for IPWireless PC Card modem for inclusion to 2.6.25.
The driver has been in -mm series as ipwireless_cs.git tree for
some time and has passed
30 matches
Mail list logo
