Re: [PATCH] irq: fix a Kconfig dependency

2014-02-04 Thread Thomas Gleixner
On Tue, 4 Feb 2014, Kamble, Nitin A wrote: > Is there any more feedback for this fix? Currently kernel is not > building for the affected platform without this fix. and I am happy > to help here to get the fix pulled in sooner. Let me know. It's in my list of stuff to apply. It'll get to Linus in

Re: [PATCH] irq: fix a Kconfig dependency

2014-02-04 Thread Kamble, Nitin A
On 1/31/2014 9:44 AM, Kamble, Nitin A wrote: On 1/31/2014 2:27 AM, David Rientjes wrote: On Thu, 30 Jan 2014, nitin.a.kam...@intel.com wrote: From: Nitin A Kamble The generic_chip.c uses interfaces from irq_domain.c which is controlled by the IRQ_DOMAIN config option. Add a select state

Re: [PATCH] irq: fix a Kconfig dependency

2014-01-31 Thread David Rientjes
On Fri, 31 Jan 2014, Kamble, Nitin A wrote: > > So, if this dependency is reasonable, it begs the question of why we have > > CONFIG_GENERIC_IRQ_CHIP at all and shouldn't just make generic-chip.c > > depend on CONFIG_IRQ_DOMAIN. > Looking at the code there are cases where IRQ_DOMAIN functionality

Re: [PATCH] irq: fix a Kconfig dependency

2014-01-31 Thread Kamble, Nitin A
On 1/31/2014 2:27 AM, David Rientjes wrote: On Thu, 30 Jan 2014, nitin.a.kam...@intel.com wrote: From: Nitin A Kamble The generic_chip.c uses interfaces from irq_domain.c which is controlled by the IRQ_DOMAIN config option. Add a select statement in the Kconfig to reflect this requirement.

Re: [PATCH] irq: fix a Kconfig dependency

2014-01-31 Thread David Rientjes
On Thu, 30 Jan 2014, nitin.a.kam...@intel.com wrote: > From: Nitin A Kamble > > The generic_chip.c uses interfaces from irq_domain.c which is controlled by > the IRQ_DOMAIN config option. > > Add a select statement in the Kconfig to reflect this requirement. > > Without this fix, the generic_c

[PATCH] irq: fix a Kconfig dependency

2014-01-30 Thread nitin . a . kamble
From: Nitin A Kamble The generic_chip.c uses interfaces from irq_domain.c which is controlled by the IRQ_DOMAIN config option. Add a select statement in the Kconfig to reflect this requirement. Without this fix, the generic_chip.c compilation fails like this: linux/kernel/irq/generic-chip.c:40