Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Russell King - ARM Linux
On Wed, Sep 16, 2015 at 05:21:57PM +0100, Russell King - ARM Linux wrote: > On Wed, Sep 16, 2015 at 10:02:32AM -0400, Eric Anholt wrote: > > Russell King - ARM Linux writes: > > > > > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: > > >> So, while FIQ isn't used in upstream, I

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Eric Anholt
Russell King - ARM Linux writes: > On Wed, Sep 16, 2015 at 10:02:32AM -0400, Eric Anholt wrote: >> Russell King - ARM Linux writes: >> >> > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: >> >> So, while FIQ isn't used in upstream, I think it's worthwhile to merge. >> >> It is

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Russell King - ARM Linux
On Wed, Sep 16, 2015 at 10:02:32AM -0400, Eric Anholt wrote: > Russell King - ARM Linux writes: > > > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: > >> So, while FIQ isn't used in upstream, I think it's worthwhile to merge. > >> It is another step to bringing the downstream

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Eric Anholt
Russell King - ARM Linux writes: > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: >> So, while FIQ isn't used in upstream, I think it's worthwhile to merge. >> It is another step to bringing the downstream developers into the fold. > > I want to see the code _first_. Until then,

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Eric Anholt
Russell King - ARM Linux writes: > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: >> So, while FIQ isn't used in upstream, I think it's worthwhile to merge. >> It is another step to bringing the downstream developers into the fold. > > I want to see the code

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Russell King - ARM Linux
On Wed, Sep 16, 2015 at 10:02:32AM -0400, Eric Anholt wrote: > Russell King - ARM Linux writes: > > > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: > >> So, while FIQ isn't used in upstream, I think it's worthwhile to merge. > >> It is another step to

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Russell King - ARM Linux
On Wed, Sep 16, 2015 at 05:21:57PM +0100, Russell King - ARM Linux wrote: > On Wed, Sep 16, 2015 at 10:02:32AM -0400, Eric Anholt wrote: > > Russell King - ARM Linux writes: > > > > > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: > > >> So, while FIQ isn't

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Eric Anholt
Russell King - ARM Linux writes: > On Wed, Sep 16, 2015 at 10:02:32AM -0400, Eric Anholt wrote: >> Russell King - ARM Linux writes: >> >> > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: >> >> So, while FIQ isn't used in upstream, I

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-14 Thread Russell King - ARM Linux
On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: > So, while FIQ isn't used in upstream, I think it's worthwhile to merge. > It is another step to bringing the downstream developers into the fold. I want to see the code _first_. Until then, I'm sorry, this patch can't go in. --

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-14 Thread Eric Anholt
Russell King - ARM Linux writes: > On Sun, Sep 13, 2015 at 09:24:48PM +0200, Noralf Trønnes wrote: >> >> Den 22.07.2015 23:32, skrev Eric Anholt: >> >Noralf Trønnes writes: >> > >> >>Add a duplicate irq range with an offset on the hwirq's so the >> >>driver can detect that enable_fiq() is

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-14 Thread Russell King - ARM Linux
On Sun, Sep 13, 2015 at 09:24:48PM +0200, Noralf Trønnes wrote: > > Den 22.07.2015 23:32, skrev Eric Anholt: > >Noralf Trønnes writes: > > > >>Add a duplicate irq range with an offset on the hwirq's so the > >>driver can detect that enable_fiq() is used. > >>Tested with downstream dwc_otg USB

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-14 Thread Eric Anholt
Russell King - ARM Linux writes: > On Sun, Sep 13, 2015 at 09:24:48PM +0200, Noralf Trønnes wrote: >> >> Den 22.07.2015 23:32, skrev Eric Anholt: >> >Noralf Trønnes writes: >> > >> >>Add a duplicate irq range with an offset on the hwirq's so the >>

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-14 Thread Russell King - ARM Linux
On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: > So, while FIQ isn't used in upstream, I think it's worthwhile to merge. > It is another step to bringing the downstream developers into the fold. I want to see the code _first_. Until then, I'm sorry, this patch can't go in. --

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-14 Thread Russell King - ARM Linux
On Sun, Sep 13, 2015 at 09:24:48PM +0200, Noralf Trønnes wrote: > > Den 22.07.2015 23:32, skrev Eric Anholt: > >Noralf Trønnes writes: > > > >>Add a duplicate irq range with an offset on the hwirq's so the > >>driver can detect that enable_fiq() is used. > >>Tested with

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-13 Thread Noralf Trønnes
Den 22.07.2015 23:32, skrev Eric Anholt: Noralf Trønnes writes: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes --- arch/arm/mach-bcm/Kconfig

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-13 Thread Noralf Trønnes
Den 22.07.2015 23:32, skrev Eric Anholt: Noralf Trønnes writes: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-23 Thread Stephen Warren
On 07/22/2015 08:07 AM, Noralf Trønnes wrote: > > Den 18.06.2015 04:26, skrev Stephen Warren: >> On 06/12/2015 11:26 AM, Noralf Trønnes wrote: >>> Add a duplicate irq range with an offset on the hwirq's so the >>> driver can detect that enable_fiq() is used. >>> Tested with downstream dwc_otg USB

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-23 Thread Stephen Warren
On 07/22/2015 08:07 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-22 Thread Eric Anholt
Noralf Trønnes writes: > Add a duplicate irq range with an offset on the hwirq's so the > driver can detect that enable_fiq() is used. > Tested with downstream dwc_otg USB controller driver. > > Signed-off-by: Noralf Trønnes > --- > arch/arm/mach-bcm/Kconfig | 1 + >

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-22 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-22 Thread Eric Anholt
Noralf Trønnes nor...@tronnes.org writes: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- arch/arm/mach-bcm/Kconfig |

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-22 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-21 Thread Stephen Warren
On 07/14/2015 05:48 AM, Noralf Trønnes wrote: > Den 14.07.2015 06:50, skrev Stephen Warren: >> On 07/11/2015 09:26 AM, Noralf Trønnes wrote: >>> Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote:

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-21 Thread Stephen Warren
On 07/14/2015 05:48 AM, Noralf Trønnes wrote: Den 14.07.2015 06:50, skrev Stephen Warren: On 07/11/2015 09:26 AM, Noralf Trønnes wrote: Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-14 Thread Noralf Trønnes
Den 14.07.2015 06:50, skrev Stephen Warren: On 07/11/2015 09:26 AM, Noralf Trønnes wrote: Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-14 Thread Noralf Trønnes
Den 14.07.2015 06:50, skrev Stephen Warren: On 07/11/2015 09:26 AM, Noralf Trønnes wrote: Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-13 Thread Stephen Warren
On 07/11/2015 09:26 AM, Noralf Trønnes wrote: > > Den 11.07.2015 06:09, skrev Stephen Warren: >> (Sorry for the slow reply; I was on vacation) >> >> On 06/18/2015 07:32 AM, Noralf Trønnes wrote: >>> Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote:

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-13 Thread Stephen Warren
On 07/11/2015 09:26 AM, Noralf Trønnes wrote: Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-11 Thread Noralf Trønnes
Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-11 Thread Stephen Warren
(Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: > Den 18.06.2015 04:26, skrev Stephen Warren: >> On 06/12/2015 11:26 AM, Noralf Trønnes wrote: >>> Add a duplicate irq range with an offset on the hwirq's so the >>> driver can detect that enable_fiq() is

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-11 Thread Stephen Warren
(Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used.

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-11 Thread Noralf Trønnes
Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 15:32, skrev Noralf Trønnes: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 15:32, skrev Noralf Trønnes: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-17 Thread Stephen Warren
On 06/12/2015 11:26 AM, Noralf Trønnes wrote: > Add a duplicate irq range with an offset on the hwirq's so the > driver can detect that enable_fiq() is used. > Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few comments/thoughts: a) Should the Kconfig change

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-17 Thread Stephen Warren
On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few comments/thoughts: a) Should the Kconfig change be

[PATCH] irqchip: bcm2835: Add FIQ support

2015-06-12 Thread Noralf Trønnes
Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes --- arch/arm/mach-bcm/Kconfig | 1 + drivers/irqchip/irq-bcm2835.c | 53

[PATCH] irqchip: bcm2835: Add FIQ support

2015-06-12 Thread Noralf Trønnes
Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- arch/arm/mach-bcm/Kconfig | 1 + drivers/irqchip/irq-bcm2835.c | 53