Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Hi Feng & Co, Apologies for the delayed follow-up. On Tue, 2016-07-19 at 10:10 +0800, Feng Li wrote: > Okay, thanks. > > Anyone could help review this patch and merge into upstream? > Applied to target-pending/for-next, with a CC' to 3.14+ stable. Thanks Feng + Sumit for tracking this down.

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Hi Feng & Co, Apologies for the delayed follow-up. On Tue, 2016-07-19 at 10:10 +0800, Feng Li wrote: > Okay, thanks. > > Anyone could help review this patch and merge into upstream? > Applied to target-pending/for-next, with a CC' to 3.14+ stable. Thanks Feng + Sumit for tracking this down.

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Okay, thanks. Anyone could help review this patch and merge into upstream? 2016-07-18 20:40 GMT+08:00 Sumit Rai : > Hi Feng, > > As per my previous comment: >>> Thanks for the patch Feng, I have tested this patch and below panic has >>> also disappeared. > patch

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Okay, thanks. Anyone could help review this patch and merge into upstream? 2016-07-18 20:40 GMT+08:00 Sumit Rai : > Hi Feng, > > As per my previous comment: >>> Thanks for the patch Feng, I have tested this patch and below panic has >>> also disappeared. > patch applied successfully and the

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Hi Feng, As per my previous comment: >> Thanks for the patch Feng, I have tested this patch and below panic has also >> disappeared. patch applied successfully and the panic has disappeared, so your fix works. Regards, Sumit Rai > On Jul 18, 2016, at 7:49 AM, Feng Li

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Hi Feng, As per my previous comment: >> Thanks for the patch Feng, I have tested this patch and below panic has also >> disappeared. patch applied successfully and the panic has disappeared, so your fix works. Regards, Sumit Rai > On Jul 18, 2016, at 7:49 AM, Feng Li wrote: > > Hi Sumit, >

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Hi Sumit, I have tested and the oops is disappeared. Could you double check if you have patched successfully? This stack is still the same. The place is 0x01f8. gdb> p (int)&((struct iscsi_session*)0)->se_sess $3 = 0x1f8 2016-07-14 17:59 GMT+08:00 Sumit Rai

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Hi Sumit, I have tested and the oops is disappeared. Could you double check if you have patched successfully? This stack is still the same. The place is 0x01f8. gdb> p (int)&((struct iscsi_session*)0)->se_sess $3 = 0x1f8 2016-07-14 17:59 GMT+08:00 Sumit Rai : > Thanks for the

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Thanks for the patch Feng, I have tested this patch and below panic has also disappeared. (initially reported at http://article.gmane.org/gmane.linux.scsi.target.devel/12735). dmesg = [ 862.784477] BUG: unable to handle kernel NULL pointer dereference at 01f8 [ 862.784486]

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Thanks for the patch Feng, I have tested this patch and below panic has also disappeared. (initially reported at http://article.gmane.org/gmane.linux.scsi.target.devel/12735). dmesg = [ 862.784477] BUG: unable to handle kernel NULL pointer dereference at 01f8 [ 862.784486]

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Add ls...@suse.com 2016-07-11 22:23 GMT+08:00 冯力 : > This problem exists at least from v3.16. > The upstream kernel still exists this issue. > > I have tested my patch and the following panic is disappeared. > > Thanks, > - Alex > > #dmesg > > [ 1160.788676] sd 16:0:0:0:

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

Add ls...@suse.com 2016-07-11 22:23 GMT+08:00 冯力 : > This problem exists at least from v3.16. > The upstream kernel still exists this issue. > > I have tested my patch and the following panic is disappeared. > > Thanks, > - Alex > > #dmesg > > [ 1160.788676] sd 16:0:0:0: [sde] Attached SCSI disk

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

This problem exists at least from v3.16. The upstream kernel still exists this issue. I have tested my patch and the following panic is disappeared. Thanks, - Alex #dmesg [ 1160.788676] sd 16:0:0:0: [sde] Attached SCSI disk [ 1383.962626] target_core_get_fabric() failed for usb_gadget [

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

This problem exists at least from v3.16. The upstream kernel still exists this issue. I have tested my patch and the following panic is disappeared. Thanks, - Alex #dmesg [ 1160.788676] sd 16:0:0:0: [sde] Attached SCSI disk [ 1383.962626] target_core_get_fabric() failed for usb_gadget [

[PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

From: Feng Li In MC/S scenario, the conn->sess has been set NULL in iscsi_login_non_zero_tsih_s1 when the second connection comes here, then kernel panic. The conn->sess will be assigned in iscsi_login_non_zero_tsih_s2. So we should check whether it's NULL before calling.

[PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

From: Feng Li In MC/S scenario, the conn->sess has been set NULL in iscsi_login_non_zero_tsih_s1 when the second connection comes here, then kernel panic. The conn->sess will be assigned in iscsi_login_non_zero_tsih_s2. So we should check whether it's NULL before calling. Signed-off-by: Feng