Re: [PATCH] isdn: hfcpci: fix potential NULL pointer dereference

2019-03-10 Thread David Miller
From: Kangjie Lu Date: Fri, 8 Mar 2019 23:46:04 -0600 > In case ioremap fails, the fix reports an error and returns. > > Signed-off-by: Kangjie Lu First, you shouldn't print the information log message if this fails. Second you are leaking hc->hw.fifos, you have to clean up any resources

[PATCH] isdn: hfcpci: fix potential NULL pointer dereference

2019-03-08 Thread Kangjie Lu
In case ioremap fails, the fix reports an error and returns. Signed-off-by: Kangjie Lu --- drivers/isdn/hardware/mISDN/hfcpci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c index ebb3fa2e1d00..b400d6528a56