Re: [PATCH] isofs: add +w bit for non-RR discs

2007-10-05 Thread Jan Engelhardt
On Oct 4 2007 20:46, Matthew Wilcox wrote: >On Tue, Oct 02, 2007 at 08:00:26PM +0200, Jan Engelhardt wrote: >> Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge > >Looks to me like you've added S_IWUSR, not S_IWUGO. Yes, S_IWUSR it should be, and is. When a user copies such a

Re: [PATCH] isofs: add +w bit for non-RR discs

2007-10-05 Thread Jan Engelhardt
On Oct 4 2007 20:46, Matthew Wilcox wrote: On Tue, Oct 02, 2007 at 08:00:26PM +0200, Jan Engelhardt wrote: Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge Looks to me like you've added S_IWUSR, not S_IWUGO. Yes, S_IWUSR it should be, and is. When a user copies such a file,

Re: [PATCH] isofs: add +w bit for non-RR discs

2007-10-04 Thread Matthew Wilcox
On Tue, Oct 02, 2007 at 08:00:26PM +0200, Jan Engelhardt wrote: > Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge Looks to me like you've added S_IWUSR, not S_IWUGO. > - popt->mode = S_IRUGO | S_IXUGO; /* > + popt->mode = S_IRUGO | S_IWUSR | S_IXUGO; > -

Re: [PATCH] isofs: add +w bit for non-RR discs

2007-10-04 Thread Matthew Wilcox
On Tue, Oct 02, 2007 at 08:00:26PM +0200, Jan Engelhardt wrote: Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge Looks to me like you've added S_IWUSR, not S_IWUGO. - popt-mode = S_IRUGO | S_IXUGO; /* + popt-mode = S_IRUGO | S_IWUSR | S_IXUGO; -

[PATCH] isofs: add +w bit for non-RR discs

2007-10-02 Thread Jan Engelhardt
Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge extensions. This allows one to modify the files right after copying, without having to do an extra recursive chmod if `cp -p` or `rsync -p` is used. References: http://lkml.org/lkml/2007/4/1/164 Signed-off-by: Jan Engelhardt

[PATCH] isofs: add +w bit for non-RR discs

2007-10-02 Thread Jan Engelhardt
Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge extensions. This allows one to modify the files right after copying, without having to do an extra recursive chmod if `cp -p` or `rsync -p` is used. References: http://lkml.org/lkml/2007/4/1/164 Signed-off-by: Jan Engelhardt