Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread SeongJae Park
On Thu, Mar 27, 2014 at 3:46 AM, David Miller wrote: > From: SeongJae Park > Date: Wed, 26 Mar 2014 19:34:21 +0900 > >> Thank you for let me know kindly :) > > Also your fix wasn't correct. > > You changed the code to use %lx but the type isn't a long. > > It's the difference between two

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread David Miller
From: SeongJae Park Date: Wed, 26 Mar 2014 19:34:21 +0900 > Thank you for let me know kindly :) Also your fix wasn't correct. You changed the code to use %lx but the type isn't a long. It's the difference between two pointers, which is ptrdiff_t. The proper printf format string for a

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread SeongJae Park
Thank you for let me know kindly :) On Wed, Mar 26, 2014 at 7:09 PM, Ian Campbell wrote: > On Wed, 2014-03-26 at 12:56 +0900, SeongJae Park wrote: >> Fix following trivial build warning: >> >> drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’: >>

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread Ian Campbell
On Wed, 2014-03-26 at 12:56 +0900, SeongJae Park wrote: > Fix following trivial build warning: > > drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’: > drivers/net/xen-netback/netback.c:1585:8: warning: > format ‘%x’ expects argument of type > ‘unsigned int’, but argument

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread Ian Campbell
On Wed, 2014-03-26 at 12:56 +0900, SeongJae Park wrote: Fix following trivial build warning: drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’: drivers/net/xen-netback/netback.c:1585:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread SeongJae Park
Thank you for let me know kindly :) On Wed, Mar 26, 2014 at 7:09 PM, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2014-03-26 at 12:56 +0900, SeongJae Park wrote: Fix following trivial build warning: drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread David Miller
From: SeongJae Park sj38.p...@gmail.com Date: Wed, 26 Mar 2014 19:34:21 +0900 Thank you for let me know kindly :) Also your fix wasn't correct. You changed the code to use %lx but the type isn't a long. It's the difference between two pointers, which is ptrdiff_t. The proper printf format

Re: [PATCH] ixen-netback: fix trivial printf format build warning

2014-03-26 Thread SeongJae Park
On Thu, Mar 27, 2014 at 3:46 AM, David Miller da...@davemloft.net wrote: From: SeongJae Park sj38.p...@gmail.com Date: Wed, 26 Mar 2014 19:34:21 +0900 Thank you for let me know kindly :) Also your fix wasn't correct. You changed the code to use %lx but the type isn't a long. It's the

[PATCH] ixen-netback: fix trivial printf format build warning

2014-03-25 Thread SeongJae Park
Fix following trivial build warning: drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’: drivers/net/xen-netback/netback.c:1585:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=] gop - vif->tx_unmap_ops,

[PATCH] ixen-netback: fix trivial printf format build warning

2014-03-25 Thread SeongJae Park
Fix following trivial build warning: drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’: drivers/net/xen-netback/netback.c:1585:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=] gop - vif-tx_unmap_ops,