Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-17 Thread Alexander Duyck
On Tue, May 17, 2016 at 2:00 AM, ethan zhao wrote: > Alexander, > > > On 2016/5/17 0:09, Alexander Duyck wrote: >> >> On Sun, May 15, 2016 at 7:59 PM, ethan zhao wrote: >>> >>> Alexander, >>> >>> On 2016/5/14 0:46, Alexander Duyck wrote: On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao >>>

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-17 Thread ethan zhao
Alexander, On 2016/5/17 0:09, Alexander Duyck wrote: On Sun, May 15, 2016 at 7:59 PM, ethan zhao wrote: Alexander, On 2016/5/14 0:46, Alexander Duyck wrote: On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less CPUs were as

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-16 Thread Jeff Kirsher
On Fri, 2016-05-13 at 14:56 +0900, Ethan Zhao wrote: > Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less > CPUs were assigned. especially when DCB is enabled, so we should take > num_online_cpus() as top limit, and aslo to make sure every TC has > at least one queue, take the MAX

Re: [Intel-wired-lan] [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-16 Thread John Fastabend
[...] >>> ixgbe_main.c. All you are doing with this patch is denying the user >>> choice with this change as they then are not allowed to set more >> >> Yes, it is purposed to deny configuration that doesn't benefit. > > Doesn't benefit who? It is obvious you don't understand how DCB is > mea

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-16 Thread Alexander Duyck
On Sun, May 15, 2016 at 7:59 PM, ethan zhao wrote: > Alexander, > > On 2016/5/14 0:46, Alexander Duyck wrote: >> >> On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao >> wrote: >>> >>> Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less >>> CPUs were assigned. especially when DCB is en

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-15 Thread ethan zhao
Thanks for your reviewing. Ethan On 2016/5/13 20:52, Sergei Shtylyov wrote: Hello. On 5/13/2016 8:56 AM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less Performance. CPUs were assigned. especially when DCB is enabled, so we should take num_online

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-15 Thread ethan zhao
Alexander, On 2016/5/14 0:46, Alexander Duyck wrote: On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less CPUs were assigned. especially when DCB is enabled, so we should take num_online_cpus() as top limit, and aslo to make s

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-13 Thread Alexander Duyck
On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao wrote: > Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less > CPUs were assigned. especially when DCB is enabled, so we should take > num_online_cpus() as top limit, and aslo to make sure every TC has > at least one queue, take the MAX

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-13 Thread Sergei Shtylyov
Hello. On 5/13/2016 8:56 AM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less Performance. CPUs were assigned. especially when DCB is enabled, so we should take num_online_cpus() as top limit, and aslo to make sure every TC has Also. at least

[PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-12 Thread Ethan Zhao
Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less CPUs were assigned. especially when DCB is enabled, so we should take num_online_cpus() as top limit, and aslo to make sure every TC has at least one queue, take the MAX_TRAFFIC_CLASS as bottom limit of queues number. Signed-off-