Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 12:39 PM, Babu Moger wrote: > Hi Alex, > > On 4/21/2016 2:22 PM, Alexander Duyck wrote: >> On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck >> wrote: >>> On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 12:39 PM, Babu Moger wrote: > Hi Alex, > > On 4/21/2016 2:22 PM, Alexander Duyck wrote: >> On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck >> wrote: >>> On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: Current code writes the tx/rx relaxed order without reading

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Babu Moger
Hi Alex, On 4/21/2016 2:22 PM, Alexander Duyck wrote: > On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck > wrote: >> On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: >>> Current code writes the tx/rx relaxed order without reading it first.

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Babu Moger
Hi Alex, On 4/21/2016 2:22 PM, Alexander Duyck wrote: > On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck > wrote: >> On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: >>> Current code writes the tx/rx relaxed order without reading it first. >>> This can lead to unintended consequences as we

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck wrote: > On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: >> Current code writes the tx/rx relaxed order without reading it first. >> This can lead to unintended consequences as we are forcibly

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck wrote: > On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: >> Current code writes the tx/rx relaxed order without reading it first. >> This can lead to unintended consequences as we are forcibly writing >> other bits. > > The consequences were

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: > Current code writes the tx/rx relaxed order without reading it first. > This can lead to unintended consequences as we are forcibly writing > other bits. The consequences were very much intended as there are situations

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: > Current code writes the tx/rx relaxed order without reading it first. > This can lead to unintended consequences as we are forcibly writing > other bits. The consequences were very much intended as there are situations where enabling relaxed

[PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Babu Moger
Current code writes the tx/rx relaxed order without reading it first. This can lead to unintended consequences as we are forcibly writing other bits. We noticed this problem while testing VF driver on sparc. Relaxed order settings for rx queue were all messed up which was causing performance drop

[PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Babu Moger
Current code writes the tx/rx relaxed order without reading it first. This can lead to unintended consequences as we are forcibly writing other bits. We noticed this problem while testing VF driver on sparc. Relaxed order settings for rx queue were all messed up which was causing performance drop