Re: [PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-19 Thread Atsushi Kumagai
Hello Vivek, On Thu, 19 Jul 2012 09:49:21 -0400 Vivek Goyal wrote: > On Wed, Jul 18, 2012 at 03:04:39PM -0700, Andrew Morton wrote: > > On Tue, 17 Jul 2012 13:36:55 -0400 > > Vivek Goyal wrote: > > > > > Last line of vmcoreinfo note does not end with \n. Parsing all the lines > > > in note

Re: [PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-19 Thread Vivek Goyal
On Wed, Jul 18, 2012 at 03:04:39PM -0700, Andrew Morton wrote: > On Tue, 17 Jul 2012 13:36:55 -0400 > Vivek Goyal wrote: > > > Last line of vmcoreinfo note does not end with \n. Parsing all the lines > > in note becomes easier if all lines end with \n instead of trying to special > > case the

Re: [PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-19 Thread Vivek Goyal
On Wed, Jul 18, 2012 at 03:04:39PM -0700, Andrew Morton wrote: On Tue, 17 Jul 2012 13:36:55 -0400 Vivek Goyal vgo...@redhat.com wrote: Last line of vmcoreinfo note does not end with \n. Parsing all the lines in note becomes easier if all lines end with \n instead of trying to special

Re: [PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-19 Thread Atsushi Kumagai
Hello Vivek, On Thu, 19 Jul 2012 09:49:21 -0400 Vivek Goyal vgo...@redhat.com wrote: On Wed, Jul 18, 2012 at 03:04:39PM -0700, Andrew Morton wrote: On Tue, 17 Jul 2012 13:36:55 -0400 Vivek Goyal vgo...@redhat.com wrote: Last line of vmcoreinfo note does not end with \n. Parsing all

Re: [PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:36:55 -0400 Vivek Goyal wrote: > Last line of vmcoreinfo note does not end with \n. Parsing all the lines > in note becomes easier if all lines end with \n instead of trying to special > case the last line. > > I know atleast one tool, vmcore-dmesg in kexec-tools tree

Re: [PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:36:55 -0400 Vivek Goyal vgo...@redhat.com wrote: Last line of vmcoreinfo note does not end with \n. Parsing all the lines in note becomes easier if all lines end with \n instead of trying to special case the last line. I know atleast one tool, vmcore-dmesg in

[PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-17 Thread Vivek Goyal
Last line of vmcoreinfo note does not end with \n. Parsing all the lines in note becomes easier if all lines end with \n instead of trying to special case the last line. I know atleast one tool, vmcore-dmesg in kexec-tools tree which made the assumption that all lines end with \n. I think it is a

[PATCH] kdump: Append newline to the last lien of vmcoreinfo note

2012-07-17 Thread Vivek Goyal
Last line of vmcoreinfo note does not end with \n. Parsing all the lines in note becomes easier if all lines end with \n instead of trying to special case the last line. I know atleast one tool, vmcore-dmesg in kexec-tools tree which made the assumption that all lines end with \n. I think it is a