Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Ingo Molnar
* Erez Zadok <[EMAIL PROTECTED]> wrote: > Ingo, I don't see how it can return NULL. This is what get_task_comm > looks like in MMOTM-2007-11-10-19-05: > > char *get_task_comm(char *buf, struct task_struct *tsk) > { > /* buf must be at least sizeof(tsk->comm) in size */ >

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Andrew Morton
On Sun, 11 Nov 2007 15:15:10 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Erez Zadok <[EMAIL PROTECTED]> wrote: > > > Small patch below fixes compile error. > > > + char name[sizeof(current->comm)]; > > warned++; > >

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Ingo Molnar writes: > > * Erez Zadok <[EMAIL PROTECTED]> wrote: > > > Small patch below fixes compile error. > > > + char name[sizeof(current->comm)]; > > warned++; > > printk(KERN_INFO > >

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Ingo Molnar
* Erez Zadok <[EMAIL PROTECTED]> wrote: > Small patch below fixes compile error. > + char name[sizeof(current->comm)]; > warned++; > printk(KERN_INFO > "warning: process `%s' sets w/ old libcap\n", > -

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Ingo Molnar
* Erez Zadok [EMAIL PROTECTED] wrote: Small patch below fixes compile error. + char name[sizeof(current-comm)]; warned++; printk(KERN_INFO warning: process `%s' sets w/ old libcap\n, -

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Erez Zadok
In message [EMAIL PROTECTED], Ingo Molnar writes: * Erez Zadok [EMAIL PROTECTED] wrote: Small patch below fixes compile error. + char name[sizeof(current-comm)]; warned++; printk(KERN_INFO

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Andrew Morton
On Sun, 11 Nov 2007 15:15:10 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: * Erez Zadok [EMAIL PROTECTED] wrote: Small patch below fixes compile error. + char name[sizeof(current-comm)]; warned++; printk(KERN_INFO

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-11 Thread Ingo Molnar
* Erez Zadok [EMAIL PROTECTED] wrote: Ingo, I don't see how it can return NULL. This is what get_task_comm looks like in MMOTM-2007-11-10-19-05: char *get_task_comm(char *buf, struct task_struct *tsk) { /* buf must be at least sizeof(tsk-comm) in size */ task_lock(tsk);

[PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-10 Thread Erez Zadok
Using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 22:46". $ make CC kernel/capability.o kernel/capability.c: In function 'sys_capset': kernel/capability.c:231: warning: passing argument 1 of 'get_task_comm' from incompatible pointer type kernel/capability.c:231:

[PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

2007-11-10 Thread Erez Zadok
Using http://userweb.kernel.org/~akpm/mmotm/ timestamped 10-Nov-2007 22:46. $ make CC kernel/capability.o kernel/capability.c: In function 'sys_capset': kernel/capability.c:231: warning: passing argument 1 of 'get_task_comm' from incompatible pointer type kernel/capability.c:231: error: