Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-14 Thread Andrey Ryabinin
On 12/13/2014 11:51 PM, Manfred Spraul wrote: > Hi, > > On 12/04/2014 12:25 AM, Andrew Morton wrote: >> On Wed, 03 Dec 2014 15:41:21 +0300 Andrey Ryabinin >> wrote: >> >>> Use the 'unsigned long' type for 'zero' variable to fix this. >>> Changing type to 'unsigned long' shouldn't affect any othe

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-13 Thread Manfred Spraul
Hi, On 12/04/2014 12:25 AM, Andrew Morton wrote: On Wed, 03 Dec 2014 15:41:21 +0300 Andrey Ryabinin wrote: Use the 'unsigned long' type for 'zero' variable to fix this. Changing type to 'unsigned long' shouldn't affect any other users of this variable. Reported-by: Dmitry Vyukov Fixes: ed4

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-05 Thread Andrew Morton
On Thu, 04 Dec 2014 07:12:45 +0100 Manfred Spraul wrote: > Hi Andrew, > > On 12/04/2014 12:25 AM, Andrew Morton wrote: > > On Wed, 03 Dec 2014 15:41:21 +0300 Andrey Ryabinin > > wrote: > > > >> Use the 'unsigned long' type for 'zero' variable to fix this. > >> Changing type to 'unsigned long'

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-04 Thread Andrey Ryabinin
On 12/04/2014 03:19 AM, Andrew Morton wrote: > On Wed, 3 Dec 2014 15:25:24 -0800 Andrew Morton > wrote: > >> On Wed, 03 Dec 2014 15:41:21 +0300 Andrey Ryabinin >> wrote: >> >>> >>> Use the 'unsigned long' type for 'zero' variable to fix this. >>> Changing type to 'unsigned long' shouldn't affe

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-03 Thread Manfred Spraul
Hi Andrew, On 12/04/2014 12:25 AM, Andrew Morton wrote: On Wed, 03 Dec 2014 15:41:21 +0300 Andrey Ryabinin wrote: Use the 'unsigned long' type for 'zero' variable to fix this. Changing type to 'unsigned long' shouldn't affect any other users of this variable. Reported-by: Dmitry Vyukov Fix

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-03 Thread Andrew Morton
On Wed, 3 Dec 2014 15:25:24 -0800 Andrew Morton wrote: > On Wed, 03 Dec 2014 15:41:21 +0300 Andrey Ryabinin > wrote: > > > > > Use the 'unsigned long' type for 'zero' variable to fix this. > > Changing type to 'unsigned long' shouldn't affect any other users > > of this variable. > > > > Re

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-03 Thread Andrew Morton
On Wed, 03 Dec 2014 15:41:21 +0300 Andrey Ryabinin wrote: > > Use the 'unsigned long' type for 'zero' variable to fix this. > Changing type to 'unsigned long' shouldn't affect any other users > of this variable. > > Reported-by: Dmitry Vyukov > Fixes: ed4d4902ebdd ("mm, hugetlb: remove hugetl

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-03 Thread David Rientjes
On Wed, 3 Dec 2014, Andrey Ryabinin wrote: > > Commit ed4d4902ebdd ("mm, hugetlb: remove hugetlb_zero and hugetlb_infinity") > replaced > 'unsigned long hugetlb_zero' with 'int zero' leading to out-of-bounds access > in proc_doulongvec_minmax(): > > ===

Re: [PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-03 Thread Rafael Aquini
On Wed, Dec 03, 2014 at 03:41:21PM +0300, Andrey Ryabinin wrote: > > Commit ed4d4902ebdd ("mm, hugetlb: remove hugetlb_zero and hugetlb_infinity") > replaced > 'unsigned long hugetlb_zero' with 'int zero' leading to out-of-bounds access > in proc_doulongvec_minmax(): > > ==

[PATCH] kernel: sysctl: use 'unsigned long' type for 'zero' variable

2014-12-03 Thread Andrey Ryabinin
Commit ed4d4902ebdd ("mm, hugetlb: remove hugetlb_zero and hugetlb_infinity") replaced 'unsigned long hugetlb_zero' with 'int zero' leading to out-of-bounds access in proc_doulongvec_minmax(): == BUG: AddressSanitize